Bug 12826

Summary: GST / VAT rewrite - plumbing
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: francois.charbonnier, julian.maurice
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12827, 12830, 12839, 12840, 12841, 12844, 12896, 12964, 12970, 12980, 13320    
Bug Blocks: 12825, 13318, 13321    
Attachments: Bug 12827: NewOrder should not return basketno
Bug 12827: NewOrder needs more unit tests

Description Jonathan Druart 2014-08-26 14:03:21 UTC
Omnibus for the plumbing part of the GST / VAT rewrite.
This is the preparation step before the rewrite.
Some inconsistencies need to be fixed.
Comment 1 Jonathan Druart 2014-08-26 15:20:20 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-08-26 15:20:23 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-08-27 08:02:58 UTC
These 2 patches should have been submitted on bug 12827...
Comment 4 Jonathan Druart 2014-08-28 10:33:30 UTC
I would like to refactor some codes related to order and bookseller.
It would be great to move this related code from C4::Acquisition to Koha::Acquisition::*

A POC is available on bug 12830.
Some plumbing patches will be marked as depend on this bug.

The goal is to refactor/clean/add unit tests without adding any regression/functionality. Like that, no need to wait for the entire feature (bug 12825) to start to push patches into master.
Comment 5 Jonathan Druart 2015-08-20 09:02:12 UTC
The plumbing is done!