|Summary:||GST / VAT rewrite - plumbing|
|Product:||Koha||Reporter:||Jonathan Druart <jonathan.druart>|
|Component:||Architecture, internals, and plumbing||Assignee:||Jonathan Druart <jonathan.druart>|
|Status:||CLOSED FIXED||QA Contact:||Testopia <testopia>|
|Priority:||P5 - low||CC:||francois.charbonnier, julian.maurice|
|Change sponsored?:||---||Patch complexity:||---|
|Who signed the patch off:||Text to go in the release notes:|
|Version(s) released in:|
|Bug Depends on:||12827, 12830, 12839, 12840, 12841, 12844, 12896, 12964, 12970, 12980, 13320|
|Bug Blocks:||12825, 13318, 13321|
Bug 12827: NewOrder should not return basketno
Bug 12827: NewOrder needs more unit tests
Description Jonathan Druart 2014-08-26 14:03:21 UTC
Omnibus for the plumbing part of the GST / VAT rewrite. This is the preparation step before the rewrite. Some inconsistencies need to be fixed.
Comment 1 Jonathan Druart 2014-08-26 15:20:20 UTC Comment hidden (obsolete)
Created attachment 31161 [details] [review] Bug 12827: NewOrder should not return basketno Since the basketno parameter is needed to insert an order, it is useless to return it. This patch changes the prototype for the C4::Acquisition::NewOrder subroutine. The return value is now a scalar containing the ordernumber created.
Comment 2 Jonathan Druart 2014-08-26 15:20:23 UTC Comment hidden (obsolete)
Created attachment 31162 [details] [review] Bug 12827: NewOrder needs more unit tests NewOrder should be more tested! This patch moves the existing unit tests into a new file and adds some unit tests. Note that there is no DB field aqorders.subscription, so the test in NewOrder can be removed. Test plan: prove t/db_dependent/Acquisition/NewOrder.t and prove t/db_dependent/Acquisition.t should return green.
Comment 3 Jonathan Druart 2014-08-27 08:02:58 UTC
These 2 patches should have been submitted on bug 12827...
Comment 4 Jonathan Druart 2014-08-28 10:33:30 UTC
I would like to refactor some codes related to order and bookseller. It would be great to move this related code from C4::Acquisition to Koha::Acquisition::* A POC is available on bug 12830. Some plumbing patches will be marked as depend on this bug. The goal is to refactor/clean/add unit tests without adding any regression/functionality. Like that, no need to wait for the entire feature (bug 12825) to start to push patches into master.
Comment 5 Jonathan Druart 2015-08-20 09:02:12 UTC
The plumbing is done!