I will try to regroup here some "documents", the developers and testers will get an overview on how vat and prices work (now and after the rewrite).
Created attachment 31742 [details] [NOT TO PUSH] Prices and VAT calculation - before This file contains all price values displayed into Koha for all pages and all supplier configurations. It will be very useful for testers and developers and QAers to test/validate other patches. All these values should be kept as it, without any changes during all the refactoring/plumbing process. I would like to get 1 signoff on it. Test plan: Create 4 suppliers (1 for each configuration) and follow the different step of the acquisition workflow. The values you see on the screen should be the same as the ones listed in this file.
Created attachment 31743 [details] [NOT TO PUSH] Prices and VAT calculation - before
I've tested against 3.17.00.025. On the IV - Configuration 4 (0 1), the increasing number of the steps is wrong: 5) has been written twice, and so the file needs to be amended: A) instead of : 5) On the Acquisition home page (acqui-home.pl) this should be written: 6) On the Acquisition home page (acqui-home.pl) B) Instead of: 6) On the Acquisition home page (acqui-home.pl) this should be written: 7) On the Acquisition home page (acqui-home.pl) C) the next line: 7) On the Acquisition home page (acqui-home.pl) has been written in the wrong place and must be cancelled. ------------------------------------ I think that an invoice has had a shipping cost of 5. And that 1 cent made no difference. ------------------------------------ So I pass the patch to "Failed QA" status.
Created attachment 31814 [details] [NOT TO PUSH] Prices and VAT calculation - before
(In reply to Paola Rossi from comment #3) Thanks Paola! > On the IV - Configuration 4 (0 1), the increasing number of the steps is > wrong: 5) has been written twice, and so the file needs to be amended: Yes, bad copy and paste at the end. It should be fixed now. > I think that an invoice has had a shipping cost of 5. > And that 1 cent made no difference. I don't understand where is the 1-cent difference.
Thanks, Jonathan. I've tested again against master 3.17.00.025, about the 1 cent' differences. -------------------------------------------------------- II - Configuration 2 (1 1) List item price includes tax Invoice item price includes tax file-doc says: 7) On the basket group (pdf English 3-page) ... gstvalue = 7.03 but I see: gstvalue = 7.02 NB. at point 10 (parcel.pl), file-doc is right. Koha shows "(Tax exc.)" on the left of the "Subtotal for ...", but this Subtotal shows 147.60, which is the Tax inc. . So the string "(Tax exc.)" is wrong, is misleading. -------------------------------------------------------- III - Configuration 3 (1 0) List item price includes tax Invoice item price does not include tax: file-doc says: 2) On the basket page (basket.pl rrp_it = 82.01 but I see: rrp_it = 82.00 file-doc says: 7) On the basket group (pdf English 3-page) ... gstvalue = 7.03 but I see: gstvalue = 7.02 -------------------------------------------------------- IV - Configuration 4 (0 1) List item price does not include tax Invoice item price includes tax: the file-doc is perfect. Al point 10 parcel.pl, file-doc is right. Koha shows "(Tax exc.)" on the left of the "Subtotal for ...", but this Subtotal shows 154.98, which is the Tax inc. So the string "(Tax exc.)" is wrong, is misleading, as in conf II. -------------------------------------------------------- I don't know if these differences of 1 cent are so substantial. In doubt I pass the patch to "Failed QA" status.
(In reply to Paola Rossi from comment #6) > Thanks, Jonathan. > > I've tested again against master 3.17.00.025, about the 1 cent' differences. > > -------------------------------------------------------- > II - Configuration 2 (1 1) > List item price includes tax > Invoice item price includes tax > > file-doc says: > 7) On the basket group (pdf English 3-page) > ... > gstvalue = 7.03 > > but I see: > gstvalue = 7.02 Arg, my fault. It is 7.02 in master (but should actually be 7.03). I will fix that. > 2) On the basket page (basket.pl > rrp_it = 82.01 > > but I see: > rrp_it = 82.00 For the configuration 3, I got 82.01, see the screenshot I will attach. Could you confirm it is 82.00 for you? > I don't know if these differences of 1 cent are so substantial. Yes, they are :)
Created attachment 31842 [details] [NOT TO PUSH] Prices and VAT calculation - before
Created attachment 31843 [details] basket for conf 3 (1 0) 82.01 vs 82.00 for configuration 3 ( 1 0 )
Thank you, Jonathan. (In reply to Jonathan Druart from comment #7) [...] > > > 2) On the basket page (basket.pl > > rrp_it = 82.01 > > > > but I see: > > rrp_it = 82.00 > > For the configuration 3, I got 82.01, see the screenshot I will attach. > Could you confirm it is 82.00 for you? > The screen you attached is about the 9) step of Conf III (see the rcvd status of the order 57). On the 9) step of Conf III I agreed with the file-doc and saw 82.01 by my side too. No problem here. On the contrary, my old note was about the 2) step of Conf III. And I confirm you that, on the 2) step of Conf III, I see 82.00 instead of the file-doc 82.01.
(In reply to Paola Rossi from comment #10) > On the contrary, my old note was about the 2) step of Conf III. > And I confirm you that, on the 2) step of Conf III, I see 82.00 instead of > the file-doc 82.01. Ho yes, I didn't notice that before! So I will reupload a new file, with a step 12 :)
Created attachment 31876 [details] [NOT TO PUSH] Prices and VAT calculation - before
Against 3.17.00.25, Conf II spet 10 does not match the doc-file. the doc-file says: Conf II: 10) On the parcel page (parcel.pl) ecost = 73.80 total_et = 140.57 gst = 7.02 total_it = 147.60 I see : Total tax exc. 140.57 Total (GST 5.0%) 7.03 Total tax inc. 147.60 So I pass the patch to "Failed QA" status
Created attachment 31895 [details] [NOT TO PUSH] Prices and VAT calculation - before
I changed step 10 for configuration II and III. The vat value is 7.03 (not 7.02) on these views.
Paola, you are amazing! Sorry not to be as meticulous as you!
Thanks, Jonathan. Everything is OK now! And the patch is signed off.
Not sure about this one - no patches?
Moving this out of the queue for now - all other patches are blocked or passed QA.
(In reply to Katrin Fischer from comment #19) > Moving this out of the queue for now - all other patches are blocked or > passed QA. There is no patch on this one. It's a document to review, see description.
I know - I just moved it when I had qa'd everything I could. We don't really have a good status for documentation :(
(In reply to Jonathan Druart from comment #20) > There is no patch on this one. > It's a document to review, see description. Suppose we could move the status to ASSIGNED and remove it from the SO queue. It does not belong here.
This was just a doc. Still useful for patches in the queue.