Bug 12964 - GST / VAT rewrite - Overview
Summary: GST / VAT rewrite - Overview
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 12826
  Show dependency treegraph
 
Reported: 2014-09-19 13:30 UTC by Jonathan Druart
Modified: 2016-06-21 21:36 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
[NOT TO PUSH] Prices and VAT calculation - before (5.29 KB, text/plain)
2014-09-19 13:37 UTC, Jonathan Druart
Details
[NOT TO PUSH] Prices and VAT calculation - before (5.29 KB, text/plain)
2014-09-19 14:03 UTC, Jonathan Druart
Details
[NOT TO PUSH] Prices and VAT calculation - before (5.25 KB, text/plain)
2014-09-22 15:40 UTC, Jonathan Druart
Details
[NOT TO PUSH] Prices and VAT calculation - before (5.25 KB, text/plain)
2014-09-23 17:08 UTC, Jonathan Druart
Details
basket for conf 3 (1 0) (20.54 KB, image/png)
2014-09-23 17:09 UTC, Jonathan Druart
Details
[NOT TO PUSH] Prices and VAT calculation - before (5.93 KB, text/plain)
2014-09-25 13:56 UTC, Jonathan Druart
Details
[NOT TO PUSH] Prices and VAT calculation - before (5.93 KB, text/plain)
2014-09-26 11:04 UTC, Jonathan Druart
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-09-19 13:30:05 UTC
I will try to regroup here some "documents", the developers and testers will get an overview on how vat and prices work (now and after the rewrite).
Comment 1 Jonathan Druart 2014-09-19 13:37:06 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-09-19 14:03:12 UTC Comment hidden (obsolete)
Comment 3 Paola Rossi 2014-09-22 14:54:24 UTC
I've tested against 3.17.00.025.

On the IV - Configuration 4 (0 1), the increasing number of the steps is wrong: 5) has been written twice, and so the file needs to be amended:

A) instead of :
5) On the Acquisition home page (acqui-home.pl)
this should be written:
6) On the Acquisition home page (acqui-home.pl)

B) Instead of:
6) On the Acquisition home page (acqui-home.pl)
this should be written:
7) On the Acquisition home page (acqui-home.pl)

C) the next line:
7) On the Acquisition home page (acqui-home.pl)
has been written in the wrong place and must be cancelled.

------------------------------------
I think that an invoice has had a shipping cost of 5.
And that 1 cent made no difference.
------------------------------------

So I pass the patch to "Failed QA" status.
Comment 4 Jonathan Druart 2014-09-22 15:40:03 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-09-22 15:42:43 UTC
(In reply to Paola Rossi from comment #3)

Thanks Paola!

> On the IV - Configuration 4 (0 1), the increasing number of the steps is
> wrong: 5) has been written twice, and so the file needs to be amended:

Yes, bad copy and paste at the end.
It should be fixed now.

> I think that an invoice has had a shipping cost of 5.
> And that 1 cent made no difference.

I don't understand where is the 1-cent difference.
Comment 6 Paola Rossi 2014-09-23 16:51:10 UTC
Thanks, Jonathan.

I've tested again against master 3.17.00.025, about the 1 cent' differences.

--------------------------------------------------------
II - Configuration 2 (1 1)
  List item price includes tax
  Invoice item price includes tax

file-doc says:
7) On the basket group (pdf English 3-page)
... 
gstvalue = 7.03

but I see:
gstvalue = 7.02

NB. at point 10 (parcel.pl), file-doc is right.

Koha shows "(Tax exc.)" on the left of the "Subtotal for ...", but this Subtotal shows 147.60, which is the Tax inc. .
So the string "(Tax exc.)" is wrong, is misleading. 
--------------------------------------------------------
III - Configuration 3 (1 0)
  List item price includes tax
  Invoice item price does not include tax:

file-doc says:
2) On the basket page (basket.pl
rrp_it = 82.01

but I see:
rrp_it = 82.00

file-doc says:
7) On the basket group (pdf English 3-page)
...
gstvalue = 7.03

but I see:
gstvalue = 7.02
--------------------------------------------------------
IV - Configuration 4 (0 1)
  List item price does not include tax
  Invoice item price includes tax:

the file-doc is perfect.

Al point 10 parcel.pl, file-doc is right.

Koha shows "(Tax exc.)" on the left of the "Subtotal for ...", but this Subtotal shows 154.98, which is the Tax inc.

So the string "(Tax exc.)" is wrong, is misleading, as in conf II.
--------------------------------------------------------

I don't know if these differences of 1 cent are so substantial.
In doubt I pass the patch to "Failed QA" status.
Comment 7 Jonathan Druart 2014-09-23 17:08:32 UTC
(In reply to Paola Rossi from comment #6)
> Thanks, Jonathan.
> 
> I've tested again against master 3.17.00.025, about the 1 cent' differences.
> 
> --------------------------------------------------------
> II - Configuration 2 (1 1)
>   List item price includes tax
>   Invoice item price includes tax
> 
> file-doc says:
> 7) On the basket group (pdf English 3-page)
> ... 
> gstvalue = 7.03
> 
> but I see:
> gstvalue = 7.02

Arg, my fault. It is 7.02 in master (but should actually be 7.03).
I will fix that.


> 2) On the basket page (basket.pl
> rrp_it = 82.01
> 
> but I see:
> rrp_it = 82.00

For the configuration 3, I got 82.01, see the screenshot I will attach.
Could you confirm it is 82.00 for you?

> I don't know if these differences of 1 cent are so substantial.

Yes, they are :)
Comment 8 Jonathan Druart 2014-09-23 17:08:51 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2014-09-23 17:09:30 UTC
Created attachment 31843 [details]
basket for conf 3 (1 0)

82.01 vs 82.00 for configuration 3 ( 1 0 )
Comment 10 Paola Rossi 2014-09-24 09:08:55 UTC
Thank you, Jonathan.

(In reply to Jonathan Druart from comment #7)
[...]
> 
> > 2) On the basket page (basket.pl
> > rrp_it = 82.01
> > 
> > but I see:
> > rrp_it = 82.00
> 
> For the configuration 3, I got 82.01, see the screenshot I will attach.
> Could you confirm it is 82.00 for you?
> 

The screen you attached is about the 9) step of Conf III (see the rcvd status of the order 57). On the 9) step of Conf III I agreed with the file-doc and saw  82.01 by my side too. No problem here.

On the contrary, my old note was about the 2) step of Conf III.
And I confirm you that, on the 2) step of Conf III, I see 82.00 instead of the file-doc 82.01.
Comment 11 Jonathan Druart 2014-09-25 13:56:14 UTC
(In reply to Paola Rossi from comment #10)
> On the contrary, my old note was about the 2) step of Conf III.
> And I confirm you that, on the 2) step of Conf III, I see 82.00 instead of
> the file-doc 82.01.

Ho yes, I didn't notice that before!
So I will reupload a new file, with a step 12 :)
Comment 12 Jonathan Druart 2014-09-25 13:56:41 UTC Comment hidden (obsolete)
Comment 13 Paola Rossi 2014-09-26 10:23:14 UTC
Against 3.17.00.25, 
Conf II spet 10 does not match the doc-file.


the doc-file says:
Conf II:
10) On the parcel page (parcel.pl)
ecost = 73.80
total_et = 140.57
gst = 7.02
total_it = 147.60


I see :
Total tax exc.	140.57	
Total (GST 5.0%)	7.03	
Total tax inc.	147.60

So I pass the patch to "Failed QA" status
Comment 14 Jonathan Druart 2014-09-26 11:04:57 UTC
Created attachment 31895 [details]
[NOT TO PUSH] Prices and VAT calculation - before
Comment 15 Jonathan Druart 2014-09-26 11:05:35 UTC
I changed step 10 for configuration II and III.
The vat value is 7.03 (not 7.02) on these views.
Comment 16 Jonathan Druart 2014-09-26 11:06:07 UTC
Paola, you are amazing! Sorry not to be as meticulous as you!
Comment 17 Paola Rossi 2014-09-26 11:55:47 UTC
Thanks, Jonathan.

Everything is OK now!

And the patch is signed off.
Comment 18 Katrin Fischer 2014-10-28 22:31:09 UTC
Not sure about this one - no patches?
Comment 19 Katrin Fischer 2014-10-30 17:19:10 UTC
Moving this out of the queue for now - all other patches are blocked or passed QA.
Comment 20 Jonathan Druart 2014-11-03 12:33:49 UTC
(In reply to Katrin Fischer from comment #19)
> Moving this out of the queue for now - all other patches are blocked or
> passed QA.

There is no patch on this one.
It's a document to review, see description.
Comment 21 Katrin Fischer 2014-11-03 12:35:33 UTC
I know - I just moved it when I had qa'd everything I could. We don't really have a good status for documentation :(
Comment 22 Marcel de Rooy 2015-01-07 15:05:00 UTC
(In reply to Jonathan Druart from comment #20)
> There is no patch on this one.
> It's a document to review, see description.

Suppose we could move the status to ASSIGNED and remove it from the SO queue. It does not belong here.
Comment 23 Jonathan Druart 2015-09-22 10:24:39 UTC
This was just a doc. Still useful for patches in the queue.