| Summary: | die with bad template path on item search because template file name has a period which is not a safe character | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Anthony Moore <ajm> |
| Component: | Searching | Assignee: | Galen Charlton <gmcharlt> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | koha-bom-get_template_and_user-regex.patch | ||
Created attachment 41488 [details] [review] koha-bom-get_template_and_user-regex.patch Attached proposed fix. Hi Anthony, could this be a duplicate of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14450? Sounds like it.. says that a fix is in 3.18.09, i'm on 3.18.08. I will try 09 and report back. |
Summary: When performing an item search in the intranet interface, KOHA dies with "bad template path at /usr/share/koha/lib/C4/Auth.pm line 161". This is because get_template_and_user is called with a template_name of "catalogue/itemsearch.csv.tt", and $safe_chars does not have the ASCII period character. Steps to reproduce: 1. Login to intranet interface 2. Click on Search on top bar 3. Click on Goto Item Search 4. Perform any item search to CSV Expected results: Search works and returns search results. Actual results: KOHA dies with the message in the summary. Suggested fix: Expand the $safe_chars regex on lib/C4/Auth.pm line 160 to include ASCII period ('.') as a valid character.