Bug 14679 - die with bad template path on item search because template file name has a period which is not a safe character
Summary: die with bad template path on item search because template file name has a pe...
Status: RESOLVED DUPLICATE of bug 14450
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-14 05:56 UTC by Anthony Moore
Modified: 2015-08-14 06:45 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
koha-bom-get_template_and_user-regex.patch (504 bytes, patch)
2015-08-14 06:11 UTC, Anthony Moore
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Moore 2015-08-14 05:56:43 UTC
Summary:

When performing an item search in the intranet interface, KOHA dies with "bad template path at /usr/share/koha/lib/C4/Auth.pm line 161". This is because get_template_and_user is called with a template_name of "catalogue/itemsearch.csv.tt", and $safe_chars does not have the ASCII period character.

Steps to reproduce:

1. Login to intranet interface
2. Click on Search on top bar
3. Click on Goto Item Search
4. Perform any item search to CSV

Expected results:

Search works and returns search results.

Actual results:

KOHA dies with the message in the summary.

Suggested fix:

Expand the $safe_chars regex on lib/C4/Auth.pm line 160 to include ASCII period ('.') as a valid character.
Comment 1 Anthony Moore 2015-08-14 06:11:58 UTC
Created attachment 41488 [details] [review]
koha-bom-get_template_and_user-regex.patch

Attached proposed fix.
Comment 2 Katrin Fischer 2015-08-14 06:16:29 UTC
Hi Anthony,

could this be a duplicate of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14450?
Comment 3 Anthony Moore 2015-08-14 06:27:50 UTC
Sounds like it.. says that a fix is in 3.18.09, i'm on 3.18.08. I will try 09 and report back.
Comment 4 Anthony Moore 2015-08-14 06:45:26 UTC
Katrin,

This bug is fixed for me in version 3.18.09. Thanks for your help.

*** This bug has been marked as a duplicate of bug 14450 ***