Summary: | Regression: Many tables' sorting broken by JavaScript error | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, christophe.croullebois, julian.maurice, m.de.rooy, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/pendingreserves.pl | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 |
||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 15925 | ||
Attachments: |
Bug 15916: Datatables - buttons area should be defined
Bug 15916: Datatables - buttons area should be defined [PASSED QA] Bug 15916: Datatables - buttons area should be defined |
Description
Owen Leonard
2016-02-25 16:38:49 UTC
The same issue affects: circ/waitingreserves.pl circ/reserveratios.pl patron_lists/lists.pl virtualshelves/shelves.pl acqui/invoices.pl ...and presumably more. Broken js on patron_lists/list.pl prevents patrons from being searched and thus prevents them from being added to a patron list. Created attachment 48431 [details] [review] Bug 15916: Datatables - buttons area should be defined Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files Set 'B' to the default dom of Datatable constructor. This cannot work if there is no button defined. This patch defined an empty 'buttons' param for this constructor, DT does not raised an error anymore when initialising. Test plan: Confirm that the tables on the following tables are not broken: - circ/waitingreserves.pl - circ/reserveratios.pl - patron_lists/lists.pl - virtualshelves/shelves.pl - acqui/invoices.pl And with datatables: - circ/circulation.pl - admin/currency.pl Created attachment 48432 [details] [review] Bug 15916: Datatables - buttons area should be defined Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files Set 'B' to the default dom of Datatable constructor. This cannot work if there is no button defined. This patch defined an empty 'buttons' param for this constructor, DT does not raised an error anymore when initialising. Test plan: Confirm that the tables on the following tables are not broken: - circ/waitingreserves.pl - circ/reserveratios.pl - patron_lists/lists.pl - virtualshelves/shelves.pl - acqui/invoices.pl And with datatables: - circ/circulation.pl - admin/currency.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48479 [details] [review] [PASSED QA] Bug 15916: Datatables - buttons area should be defined Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files Set 'B' to the default dom of Datatable constructor. This cannot work if there is no button defined. This patch defined an empty 'buttons' param for this constructor, DT does not raised an error anymore when initialising. Test plan: Confirm that the tables on the following tables are not broken: - circ/waitingreserves.pl - circ/reserveratios.pl - patron_lists/lists.pl - virtualshelves/shelves.pl - acqui/invoices.pl And with datatables: - circ/circulation.pl - admin/currency.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> pushed to master - should be in the May 2016 release. Thanks! Does not concern stable versions, status changed to RESOLVED |