Summary: | Remove unused images from the staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 16020, 16023, 16025, 16027, 16032, 16043, 16045, 16046, 16059, 16071, 16206, 16241 | ||
Bug Blocks: | |||
Attachments: |
Bug 16080 - Remove unused images from the staff client
Bug 16080 [Revised] Remove unused images from the staff client [SIGNED-OFF] Bug 16080 [Revised] Remove unused images from the staff client [PASSED QA] Bug 16080 [Revised] Remove unused images from the staff client |
Description
Owen Leonard
2016-03-15 16:25:48 UTC
Created attachment 50590 [details] [review] Bug 16080 - Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Testing on top of Bug 16241: git grep glyphicons-halflings-koha.png koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt (line 28) The file contains more references, e.g. cart-small.gif (not in list in this patch) All others in list are OK Created attachment 50837 [details] [review] Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt Created attachment 50846 [details] [review] [SIGNED-OFF] Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of Bug 16241 No reference of deleted files (only on PO files but that will be fixed later) No errors Created attachment 50893 [details] [review] [PASSED QA] Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of Bug 16241 No reference of deleted files (only on PO files but that will be fixed later) No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the 16.05 release. Thanks Owen! |