Summary: | Fines note not showing on checkout | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Patrons | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, francois.charbonnier, gmcharlt, hector.hecaxmmx, julian.maurice, kyle.m.hall, kyle, nick, veron, vimalibre |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 16861 | ||
Attachments: |
no fines warning
Bug 16810 - Fines note not showing on checkout [SIGNED-OFF]Bug 16810: Fines note not showing on checkout [PASSED QA] Bug 16810: Fines note not showing on checkout |
Description
Nicole C. Engard
2016-06-24 19:47:41 UTC
Appears to be a regression from bug 14497 - the entire block is inside this if: [% IF NoIssuesCharge && fines > NoIssuesCharge %] So you don't get the warning about having any fines unless you have fines over the NoIssuesCharge Same issue on master. Created attachment 53125 [details] [review] Bug 16810 - Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Created attachment 53137 [details] [review] [SIGNED-OFF]Bug 16810: Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Hm, a fine not exceeding noissuecharge isn't showing for me, but it should. Sorry... didn't test this right (you should actually apply the patch... right?). But good news is, that this works fine. Created attachment 53301 [details] [review] [PASSED QA] Bug 16810: Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Marc! Pushed in 16.05. Will be in 16.05.02. *** Bug 16957 has been marked as a duplicate of this bug. *** Not needed in 3.22.x *** Bug 17442 has been marked as a duplicate of this bug. *** |