This patch propose to fix this two entries in PO files: #: intranet-tmpl/prog/en/modules/circ/circulation.tt:797 #, c-format msgid ". See highlighted items " msgstr ". Véase los ítems resaltados " #: intranet-tmpl/prog/en/modules/circ/circulation.tt:797 #, c-format msgid "below" msgstr "debajo" Also add some Font Awesome Icons to circulation interface.
Created attachment 53142 [details] [review] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Go to a patron how has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links
Created attachment 53143 [details] [review] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues in checkout tab -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links
Created attachment 53150 [details] [review] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 53170 [details] [review] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Héctor, I have asked Owen (on #koha) if he agrees on the fa-hand-o-down icon and he does not :) Could you please remove it?
Created attachment 53193 [details] [review] Bug 16861: (followup)Translatability: remove fa-hand-o-down icon Remove fa-hand-o-down icon accoring with QA comment 5
I am ok with the new sentence, but I have a general question about the buttons vs icons: Example 1: Make payment and Pay all fines are buttons: Fees & Charges: Patron has outstanding fees & charges of 0,01. Make payment Pay all fines Example 2: Delete and Add a new message are Links with icons: 06/01/2016 Midway "WAAH" [Delete] Add a new message Should we not pick one or the other? Owen, could you take a look?
We don't have a firm rule for this, though it's something we should consider for the interface guidelines. In general I like to use a link when it's part of a block of text like this. I don't think it's an issue which should hold up this patch.
Created attachment 53757 [details] [review] [PASSED QA] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 53758 [details] [review] [PASSED QA] Bug 16861: (followup)Translatability: remove fa-hand-o-down icon Remove fa-hand-o-down icon accoring with QA comment 5 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
pushed to master - Should be in the November 2016 release. Thanks!