Bug 17442 - Fees and charges warning on the circulation page. Rollback to the original behaviour
Summary: Fees and charges warning on the circulation page. Rollback to the original be...
Status: RESOLVED DUPLICATE of bug 16810
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-13 17:56 UTC by Francois Charbonnier
Modified: 2016-10-14 13:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17442 - Reinstate patron's fine warning that was lost with bug 14497 (2.88 KB, patch)
2016-10-13 18:08 UTC, Blou
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Charbonnier 2016-10-13 17:56:59 UTC
Bug 14497 added a warning to patron details page if patron's fines exceed noissuescharge. But it also changes the condition to display the warning on the circulation page.

Until 16.05, the staff could see the fees and charges warning on the circulation page when the patron had fines. But, with Bug 14497, the warning appears only when the patron's fines exceed the noissuescharge syspref.

I'm sure this change of behaviour wasn't meant to be. Especially, since there is nothing in place to keep the original behaviour.

This patch will keep the new warning on he patron detail page. It will rollback the warning to the original behaviour. The fees and charges warning will show up no matter how much the patron owes to the library.

Test plan :

1) Apply this patch
2) Find or create a patron who's fines doesn't exceed noissuescharge
3) You should see the fees and charges warning on the circulation page (circulation.pl)
4) Browse to the patron's details page (moremember.pl). The warning doesn't appear
5) Find or create a patron who's fines exceed noissuescharge
5) Browse to that patron's details ( moremember.pl )
6) You should see a warning near the top of the page
Comment 1 Francois Charbonnier 2016-10-13 18:06:27 UTC
It will rollback the warning to the original behaviour on the circulation page*
Comment 2 Blou 2016-10-13 18:08:28 UTC
Created attachment 56439 [details] [review]
Bug 17442 - Reinstate patron's fine warning that was lost with bug 14497

Bug 14497 added a warning to patron details page if patron's fines exceed noissuescharge, but it also
changed the condition to display the warning on the circulation page.  Until 16.05, the staff could see the
fees and charges warning on the circulation page when the patron had fines. But, with Bug 14497, the warning
appears only when the patron's fines exceed the noissuescharge syspref.

This patch will keep the new warning on he patron detail page.
It will rollback the warning to the original behaviour.
The fees and charges warning will show up no matter how much the patron owes to the library.

Test plan :

1) Apply this patch
2) Find or create a patron who's fines doesn't exceed noissuescharge
3) You should see the fees and charges warning on the circulation page (circulation.pl)
4) Browse to the patron's details page (moremember.pl). The warning doesn't appear
5) Find or create a patron who's fines exceed noissuescharge
5) Browse to that patron's details ( moremember.pl )
6) You should see a warning near the top of the page
Comment 3 Claire Gravely 2016-10-14 07:44:51 UTC
Hi, I am a little confused. I am not seeing a change in the behaviour between master and this patch?

I see the fines warning displayed on the moremember.pl page and circulation.pl pages both when the patron has fines that exceed noissuescharge and also when they don't. 

Was the issue already fixed?
Comment 4 Francois Charbonnier 2016-10-14 13:23:52 UTC
Thanks Claire. I checked again on Bugzilla and found out that it was already fixed by Bug 16810 a couple months ago.

*** This bug has been marked as a duplicate of bug 16810 ***