| Summary: | unimarc plugin 4xx template noise | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Staff interface | Assignee: | Mark Tompsett <mtompset> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16856 - unimarc plugin 4xx template noise
Bug 16856 - unimarc plugin 4xx template noise |
||
|
Description
Mark Tompsett
2016-07-06 02:44:55 UTC
Created attachment 53121 [details] [review] Bug 16856 - unimarc plugin 4xx template noise While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was run. This triggers UNIMARC 4xx plugin noise. The issue is that itypeloo.selected is not a property that exists in the hash parameter to the template. git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po: The above was used to confirm that there is only one file which affects that template: cataloguing/value_builder/unimarc_field_4XX.pl There is only one way for the Search value to evaluate to true: the else case of the $op check (right at the bottom of the file). The value passed to the itypeloop parameter is a full search from Koha::ItemTypes->search, which has no parameters passed to it, and does not return a 'selected' key as part of the array of hashes. The logic to try to set "selected" in the template makes no sense, as a result, since it is only called with a value that never has "selected" set. The fix is easy: cut the useless code. TEST PLAN --------- 1) prove t/db_dependent/FrameworkPlugin.t -- see unimarc 4xx related noise. 2) apply patch 3) prove t/db_dependent/FrameworkPlugin.t -- no more unimarc 4xx related noise. 4) run koha qa test tools Created attachment 53409 [details] [review] Bug 16856 - unimarc plugin 4xx template noise While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was run. This triggers UNIMARC 4xx plugin noise. The issue is that itypeloo.selected is not a property that exists in the hash parameter to the template. git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po: The above was used to confirm that there is only one file which affects that template: cataloguing/value_builder/unimarc_field_4XX.pl There is only one way for the Search value to evaluate to true: the else case of the $op check (right at the bottom of the file). The value passed to the itypeloop parameter is a full search from Koha::ItemTypes->search, which has no parameters passed to it, and does not return a 'selected' key as part of the array of hashes. The logic to try to set "selected" in the template makes no sense, as a result, since it is only called with a value that never has "selected" set. The fix is easy: cut the useless code. TEST PLAN --------- 1) prove t/db_dependent/FrameworkPlugin.t -- see unimarc 4xx related noise. 2) apply patch 3) prove t/db_dependent/FrameworkPlugin.t -- no more unimarc 4xx related noise. 4) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> |