Summary: | CSS regression: white gap on the top of the staff pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | alexbuckley, fridolin.somers, gmcharlt, jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7760, 19981 | ||
Bug Blocks: | |||
Attachments: |
Screenshot of the new white gap on the top of the page.
Bug 20268: CSS regression: white gap on the top of the staff pages Bug 20268: CSS regression: white gap on the top of the staff pages Bug 20268: CSS regression: white gap on the top of the staff pages Bug 20268 (follow-up) Correct template error |
Description
Victor Grousset/tuxayo
2018-02-22 10:11:56 UTC
Comes from staff-global.css : .main { margin-top: 1em; } main class is on body in intranet-main.tt. It is usually in : <div class="main container-fluid"> @Fridolin: Why does it depends on bug 7760 ? Created attachment 72310 [details] [review] Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Created attachment 72339 [details] [review] Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 72344 [details] [review] Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> *** Bug 20328 has been marked as a duplicate of this bug. *** Pushed to master for 18.05, thanks to everybody involved! A test is failing, please fix ASAP: xt/tt_valid.t .. 1/3 # Failed test '<body> tag with id and class attributes' # at xt/tt_valid.t line 91. # Files list: # intranet-tmpl/prog/en/modules/auth.tt: 15 https://jenkins.koha-community.org/job/Koha_Master_D8/398/ Created attachment 73180 [details] [review] Bug 20268 (follow-up) Correct template error The login template must have a class attribute on the body tag in order for the template to pass tests. To test, apply the patch and confirm that the staff client login form still looks the same. For further confirmation you could update the IntranetUserCSS system preference with something like this: .main_main-auth { background-color: #CCF; } The login form should now have a different background color. (In reply to Owen Leonard from comment #9) > Created attachment 73180 [details] [review] [review] > Bug 20268 (follow-up) Correct template error Pushed to master. |