Bug 20328 - White margin at the top of the home page of the staff client
Summary: White margin at the top of the home page of the staff client
Status: RESOLVED DUPLICATE of bug 20268
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 03:38 UTC by Alex Buckley
Modified: 2018-03-05 07:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client (1.14 KB, patch)
2018-03-04 03:49 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client (1.33 KB, patch)
2018-03-05 01:28 UTC, Dilan Johnpullé
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2018-03-04 03:38:37 UTC
There is a 13px high white margin at the top of the home page of the Koha staff client. 

After doing a git bisect I found that this bug was introduced in the patch for bug 19981 with the following addition to staff-global.css:

.main {
   margin-top: 1em;
}
Comment 1 Alex Buckley 2018-03-04 03:49:10 UTC
Created attachment 72393 [details] [review]
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client

I identified the source of this bug from using a git bisect and have
removed the addition of the margin from the staff-global.css

Test plan:
1. Go to the home page of the staff client and notice that there is a
white margin (line) at the top of the page

2. Apply patch

3. Refresh the page and notice that the white margin is no longer
displayed

Sponsored-By: Catalyst IT
Comment 2 Dilan Johnpullé 2018-03-05 01:28:03 UTC
Created attachment 72397 [details] [review]
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client

I identified the source of this bug from using a git bisect and have
removed the addition of the margin from the staff-global.css

Test plan:
1. Go to the home page of the staff client and notice that there is a
white margin (line) at the top of the page

2. Apply patch

3. Refresh the page and notice that the white margin is no longer
displayed

Sponsored-By: Catalyst IT

Patch applies and functions as expected.
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 3 Claire Gravely 2018-03-05 07:28:25 UTC
I think this is a duplicate of bug 20268

*** This bug has been marked as a duplicate of bug 20268 ***