Bug 20328

Summary: White margin at the top of the home page of the staff client
Product: Koha Reporter: Alex Buckley <alexbuckley>
Component: Staff interfaceAssignee: Alex Buckley <alexbuckley>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: claire_gravely, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client

Description Alex Buckley 2018-03-04 03:38:37 UTC
There is a 13px high white margin at the top of the home page of the Koha staff client. 

After doing a git bisect I found that this bug was introduced in the patch for bug 19981 with the following addition to staff-global.css:

.main {
   margin-top: 1em;
}
Comment 1 Alex Buckley 2018-03-04 03:49:10 UTC
Created attachment 72393 [details] [review]
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client

I identified the source of this bug from using a git bisect and have
removed the addition of the margin from the staff-global.css

Test plan:
1. Go to the home page of the staff client and notice that there is a
white margin (line) at the top of the page

2. Apply patch

3. Refresh the page and notice that the white margin is no longer
displayed

Sponsored-By: Catalyst IT
Comment 2 Dilan Johnpullé 2018-03-05 01:28:03 UTC
Created attachment 72397 [details] [review]
Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client

I identified the source of this bug from using a git bisect and have
removed the addition of the margin from the staff-global.css

Test plan:
1. Go to the home page of the staff client and notice that there is a
white margin (line) at the top of the page

2. Apply patch

3. Refresh the page and notice that the white margin is no longer
displayed

Sponsored-By: Catalyst IT

Patch applies and functions as expected.
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 3 Claire Gravely 2018-03-05 07:28:25 UTC
I think this is a duplicate of bug 20268

*** This bug has been marked as a duplicate of bug 20268 ***