Description
Martin Renvoize
2019-03-15 14:47:57 UTC
Created attachment 86808 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Not ready for testing yet.. UI side still needs a patch Created attachment 86890 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86891 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86892 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86893 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86894 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86895 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86896 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86897 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86898 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Test Plan 1) Apply patch and ensure updated tests still pass 2) Run DB updates and ensure the display of status's makes sense on all pages that display accountline details (account summary, print and payment pages on staff and the user account fines page on the opac) Created attachment 86899 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86900 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86901 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86902 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86918 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86919 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86920 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86921 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Comment on attachment 86919 [details] [review] Bug 22521: Update fines handling to use accountline.status Review of attachment 86919 [details] [review]: ----------------------------------------------------------------- ::: Koha/Account.pm @@ +471,4 @@ > itemnumber => $item_id, > issue_id => $issue_id, > branchcode => $library_id, > + ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()), Does it make sense to you to make this dependent also on 22516, which removes lastincrement column? And the tests are not passing: t/db_dependent/Circulation.t .. 36/126 Type of debit not recognised# Looks like your test exited with 255 just after 37. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 89/126 subtests t/db_dependent/Overdues.t ..... 4/17 # Looks like you planned 25 tests but ran 1. t/db_dependent/Overdues.t ..... 17/17 # Failed test 'UpdateFine tests' # at t/db_dependent/Overdues.t line 307. Type of debit not recognised# Looks like your test exited with 255 just after 17. t/db_dependent/Overdues.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/17 subtests git grep "fine_update" returns: C4/Overdues.pm: $accountline->adjust({ amount => $amount, type => 'fine_update' }); t/db_dependent/Koha/Account/Lines.t: throws_ok { $debit_1->adjust( { amount => 50, type => 'fine_update' } ) } t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 150, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 160, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 50, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 30, type => 'fine_update' } )->discard_changes; Created attachment 87063 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Created attachment 87083 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87084 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87085 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87086 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87087 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Created attachment 87097 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87098 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87099 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87100 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87101 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> (In reply to Josef Moravec from comment #21) > Comment on attachment 86919 [details] [review] [review] > Bug 22521: Update fines handling to use accountline.status > > Review of attachment 86919 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: Koha/Account.pm > @@ +471,4 @@ > > itemnumber => $item_id, > > issue_id => $issue_id, > > branchcode => $library_id, > > + ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()), > > Does it make sense to you to make this dependent also on 22516, which > removes lastincrement column? Thanks for the quick testing and signoff. Can't believe I let those tests slip through in that state. As for the dependency on bug 22516.. Isort of agree but didn't want to make the tree look too complicated.. hopefully it'll be pushed imminently and it should be a trivial rebase. Created attachment 87209 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87210 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87211 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87212 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87213 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Created attachment 87214 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Created attachment 87215 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87216 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87217 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87218 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87219 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87220 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> *** Bug 22519 has been marked as a duplicate of this bug. *** Created attachment 87619 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87620 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87621 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87622 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87623 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87624 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Freshly re-based and ready for QA Created attachment 87678 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87679 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87680 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87681 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87682 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87683 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87787 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87788 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87789 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87790 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87791 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87792 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Freshly rebased on new dependancies Looks good! I only have a one issue: Shouldn't VOID be in these blocks on the staff and opac side? [%- BLOCK account_status_description -%] [%- SWITCH account.status -%] [%- CASE 'UNRETURNED' -%]<span> (Accruing)</span> [%- CASE 'RETURNED' -%]<span> (Returned)</span> [%- CASE 'FORGIVEN' -%]<span> (Forgiven)</span> [%- CASE -%] [%- END -%] [%- END -%] See the dependency tree.. the VOID state is added further down the tree and as such it's introduced as you suggest there.. my brain couldn't keep it all in my head for one massive bug.. Excellent! I was reading the tree backwards! My Bad ;) (In reply to Martin Renvoize from comment #70) > See the dependency tree.. the VOID state is added further down the tree and > as such it's introduced as you suggest there.. my brain couldn't keep it all > in my head for one massive bug.. Created attachment 87808 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87809 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87810 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87811 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87812 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87813 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87814 [details] [review] Bug 22521: (QA Followup) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Oh, this needs a quick follow-up which I'll post tomorrow.. FFOR got reintroduced in the last rebase, just needs re-removing from the UI display patch. Applying: Bug 22521: Increase varchar size for accounttype Applying: Bug 22521: Update fines handling to use accountline.status error: sha1 information is lacking or useless (C4/Circulation.pm). Created attachment 87850 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87851 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87852 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87853 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87854 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87855 [details] [review] Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87856 [details] [review] Bug 22521: (QA Followup) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87857 [details] [review] Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87858 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87859 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87860 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87861 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87862 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87863 [details] [review] Bug 22521: (QA follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87864 [details] [review] Bug 22521: (QA follow-up) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 87865 [details] [review] Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Following this trail, it still does not apply. Can we wait for some things to get pushed btw ? 22628 21953 22547 22521 Created attachment 88064 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88065 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88066 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88067 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88068 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88069 [details] [review] Bug 22521: (QA follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88070 [details] [review] Bug 22521: (QA follow-up) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88071 [details] [review] Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88149 [details] [review] Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88150 [details] [review] Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88151 [details] [review] Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88152 [details] [review] Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88153 [details] [review] Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88154 [details] [review] Bug 22521: (QA follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88155 [details] [review] Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88156 [details] [review] Bug 22521: (QA follow-up) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Awesome work all! Pushed to master for 19.05 Created attachment 88286 [details] [review] Bug 22521: (RM follow-up) Adjust tests to use new accounttype (In reply to Nick Clemens from comment #115) > Created attachment 88286 [details] [review] [review] > Bug 22521: (RM follow-up) Adjust tests to use new accounttype Followup pushed to master Enhancement will not be backported to 18.11.x series. |