Bug 22521 changes the accounttype values for fines and adds a new status field. maninvoice.pl does not use these new values. To test: - find a patron and create a manual invoice of type "Fine" - look at the database to see that manual fine is accounttype=F and status=NULL That should be accounttype=OVERDUE. I'm not sure what status should be. NULL? RETURNED? Prior to 19.05, a manually created fine is indistinguishable from a normal fine.
OK, so this is a case I wasn't expecting at all :(. I'll have a quick ponder as to the best solution as I'm currently working towards the unification and clarification of these manual invoice types in bug 23049 and will need to account for this use case there as well as building something for working with here separately.
Hi Andrew.. I presume your users were manually entering the accounttype code in the box. Could you check for me whether they were manually adding any other system accounttypes (like FU for instance) in he hope of triggering the standard processing again?
Created attachment 94306 [details] [review] Bug 23826: Correction for missing "F" -> "OVERDUE" change When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the maninvoice template. This patch should correct that mistake.
Created attachment 94322 [details] [review] Bug 23826: Correction for missing "F" -> "OVERDUE" change When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the maninvoice template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
- created Manual Invoice of type Fine - ran report to see that accountlines entry - confirmed it is accounttype=OVERDUE, status=NULL Thanks again, Martin!
Created attachment 94355 [details] [review] Bug 23826: Correction for missing "F" -> "OVERDUE" change When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the maninvoice template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Nice work! Pushed to master for 19.11.00
Conflict on 19.05.x because there is : <option value="L">Lost item</option> instead of <option value="LOST">Lost item</option> Looks like its from Bug 22563 not in 19.05.x : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91345 Pushed to 19.05.x for 19.05.05