| Summary: | Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21772 | ||
| Bug Blocks: | |||
| Attachments: | Bug 24095: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page | ||
|
Description
Owen Leonard
2019-11-22 19:57:20 UTC
From commit 6a7d4b19c7fa224fc1a5abd596a81d3ca52f43f9 Bug 21772: Move OPAC holds and account tables into .inc Also needed in sco/sco-main.tt Created attachment 96795 [details] [review] Bug 24095: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page This patch corrects markup in the table of holds in the OPAC so that the hold deletion confirmation message appears correctly. The onclick event removed from holds-table.inc was made obsolete by Bug 21870. To test, apply the patch and log in to the OPAC as a user who has holds. - From the "your summary" page in the OPAC, open the holds tab. - Click any "Cancel" button. You should be shown a confirmation modal. - Test both the confirm and cancel operations. - Log in to self-checkout and confirm that the holds tab there is unaffected: Although it uses the same include, the hold cancellation option isn't shown there. |