Bug 24095 - Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page
Summary: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page
Status: RESOLVED DUPLICATE of bug 24433
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 21772
Blocks:
  Show dependency tree / graph
 
Reported: 2019-11-22 19:57 UTC by Owen Leonard
Modified: 2020-01-21 13:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 24095: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page (2.80 KB, patch)
2020-01-03 17:23 UTC, Owen Leonard 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-11-22 19:57:20 UTC 
On the "my summary" page in the OPAC, under the holds tab, clicking the delete button for a hold should trigger a confirmation message. The MSG_CONFIRM_DELETE_HOLD is not defined so the confirmation is skipped and the hold is deleted without confirmation.
Comment 1 Jonathan Druart 2019-11-27 13:29:42 UTC 
From
  commit 6a7d4b19c7fa224fc1a5abd596a81d3ca52f43f9
  Bug 21772: Move OPAC holds and account tables into .inc


Also needed in sco/sco-main.tt
Comment 2 Owen Leonard 2020-01-03 17:23:51 UTC 
Created attachment 96795 [details] [review]
Bug 24095: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page

This patch corrects markup in the table of holds in the OPAC so that the
hold deletion confirmation message appears correctly. The onclick event
removed from holds-table.inc was made obsolete by Bug 21870.

To test, apply the patch and log in to the OPAC as a user who has holds.

 - From the "your summary" page in the OPAC, open the holds tab.
 - Click any "Cancel" button. You should be shown a confirmation modal.
 - Test both the confirm and cancel operations.
 - Log in to self-checkout and confirm that the holds tab there is
   unaffected: Although it uses the same include, the hold cancellation
   option isn't shown there.
Comment 3 Owen Leonard 2020-01-21 13:23:34 UTC 
I duped my own patch!

*** This bug has been marked as a duplicate of bug 24433 ***