Bug 21772 - Add holds and account information tab to the SCO module
Summary: Add holds and account information tab to the SCO module
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: 19.05
Assignee: Agustín Moyano
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
: 9047 (view as bug list)
Depends on:
Blocks: 22538
  Show dependency treegraph
 
Reported: 2018-11-06 15:07 UTC by Jesse Maseto
Modified: 2019-03-19 14:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21772: Move OPAC holds and account tables into .inc (48.93 KB, patch)
2019-03-07 23:08 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 21772: (follow-up) QA failed because old bootstrap button class (1.67 KB, patch)
2019-03-07 23:08 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 21772: Add holds and account information to SCO (19.21 KB, patch)
2019-03-07 23:08 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 21772: (follow-up) Remove redundant variable (803 bytes, patch)
2019-03-07 23:09 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 21772: (follow-up) Included more information on tab label for SCO (1.66 KB, patch)
2019-03-12 01:59 UTC, Agustín Moyano
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Maseto 2018-11-06 15:07:56 UTC
Work to be:
1) Move opac-user.pl holds tab content into include file
2) Add holds to to sco, use new include file
3) Add patron fines info to sco.
4) Modify script to search for and pass in patron holds
Comment 1 Agustín Moyano 2019-03-07 23:08:50 UTC
Created attachment 86331 [details] [review]
Bug 21772: Move OPAC holds and account tables into .inc

This patch moves the code to render the account and holds information
for the patron into include files. They are loaded in the opac-user.tt
and opac-account.tt templates respectively.

To test:
1) Have a patron with account lines and holds
2) Notice they are displayed in the patron's detail section in the OPAC
3) Apply this patch
4) Reload the patron's detail page
=> SUCESS: Everything looks the same, no behaviuor or layout change.
5) Sign off

Sponsored-by: City of Portsmouth Public Library
Comment 2 Agustín Moyano 2019-03-07 23:08:53 UTC
Created attachment 86332 [details] [review]
Bug 21772: (follow-up) QA failed because old bootstrap button class
Comment 3 Agustín Moyano 2019-03-07 23:08:56 UTC
Created attachment 86333 [details] [review]
Bug 21772: Add holds and account information to SCO

This patch introduces holds and account information to the SCO page. It
uses the introduced include files that are also used in OPAC
(opac-user.pl and opac-account.pl).

To test:
1) Have a patron that has holds and account lines
2) Enable the SCO module
3) Use the patron's cardnumber to get to its details
=> SUCCESS: New tabs are presented, and they display holds and account
information as expected
4) Sign off :-D

Sponsored-by: City of Portsmouth Public Library
Comment 4 Agustín Moyano 2019-03-07 23:09:00 UTC
Created attachment 86334 [details] [review]
Bug 21772: (follow-up) Remove redundant  variable

Sponsored-by: City of Portsmouth Public Library
Comment 5 Tomás Cohen Arazi 2019-03-08 09:54:36 UTC
*** Bug 9047 has been marked as a duplicate of this bug. ***
Comment 6 Sarah Cornell 2019-03-11 18:36:35 UTC
Agustín,

I tested the patch and the functionality works.  Is it possible to include more information in the tab labels in SCO, as it is displayed in opac-user.pl? 

Such as: 

Checkouts (0) Holds (1) Fines and charges (16.99) 


Thanks,

Sarah
Comment 7 Agustín Moyano 2019-03-12 01:59:00 UTC
Created attachment 86495 [details] [review]
Bug 21772: (follow-up) Included more information on tab label for SCO
Comment 8 Sarah Cornell 2019-03-12 21:28:08 UTC
The tabs look good.  I'm almost ready to sign off.  

At some point in my testing the SCO shut down.  I think it was because the SCO was trying to edit an item as part of the normal process.  I reproduced the shutdown when I tried to edit an item in the intranet.  This is one of the last lines of the plack log when it shuts down:

Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 853.
2019/03/12-19:48:38 Server closing!

I don't see why it would be related but I'm new to testing on the sandboxes so I have to ask!
Comment 9 Agustín Moyano 2019-03-14 10:44:10 UTC
Hello Sarah,

I believe that behaviour isn't related with this bug.

I think somehow SCO and intranet are overwritting the others browser cookies.

Please try opening each one in different browsers, or one in incognito mode.

Thanks
Comment 10 Sarah Cornell 2019-03-14 14:02:28 UTC
I got the same behavior (tab closes when invoking additem.pl) when testing another bug in the sandboxes, even after clearing cookies and only using the intranet.  So I guess it is unrelated to this bug.  

I'm signing off because your patches work. If this isn't the right thing to do, I'm sure someone will let me know!