Summary: | Add a 'search to order' function | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | new feature | ||
Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This new feature allows staff to add items to an order via a new 'Search to order' function accessible from the basket. The order can then be created either directly from the result list or the detail pages of the catalog.
This replaces the former search functionality for existing records within the acquisitions module and makes it possible to use all search features and information shown in the normal catalog.
|
Version(s) released in: |
20.05.00
|
Circulation function: | |||
Bug Depends on: | 23944 | ||
Bug Blocks: | 27900 | ||
Attachments: |
Bug 24347: Add a 'search to order' option similar to 'search to hold'
Bug 24347: (follow-up) Remove custom catalog search from acquisitions Bug 24347: Add a 'search to order' option similar to 'search to hold' Bug 24347: (follow-up) Remove custom catalog search from acquisitions Bug 24347: Add a 'search to order' option similar to 'search to hold' Bug 24347: (follow-up) Remove custom catalog search from acquisitions |
Description
Katrin Fischer
2020-01-05 11:08:53 UTC
If anyone is interested in this feature I recommend helping test Bug 23944, "Phase out use of jquery.cookie.js in favor of js.cookie.js" which I would view as a dependency. Created attachment 96838 [details] [review] Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC, ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. Created attachment 96839 [details] [review] Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. Created attachment 97948 [details] [review] Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC (enable viewLabeledMARC system preference), ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. Signed-off-by: David Nind <david@davidnind.com> Created attachment 97949 [details] [review] Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98101 [details] [review] Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC, ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 98102 [details] [review] Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx a lot Owen for picking up my idea and running with it! Possible improvement I could imagine: - Add a link to jump directly to Advanced search - Improve the styling of the 'Add to order' pop up to make all our different options a bit easier to handle (not related to this bug actually) This introduces a new cookie right.. should this get recorded on the wiki page for cookies? https://wiki.koha-community.org/wiki/Use_of_Cookies - Katrin or Owen.. could you do the honours pretty please. Nice work everyone! Pushed to master for 20.05 (In reply to Martin Renvoize from comment #10) > https://wiki.koha-community.org/wiki/Use_of_Cookies - Katrin or Owen.. could > you do the honours pretty please. I already added a personal tag about it yesterday :) Is there a way we could mark them otherwise/publicly? I have an update of the cookie docs on the agenda since I think I found a few missing. Could add a public keyword I suppose.. I use those allot to share States with people.. like the Manual and needs-release-notes.. how about 'new-cookie' ? (In reply to Martin Renvoize from comment #13) > Could add a public keyword I suppose.. I use those allot to share States > with people.. like the Manual and needs-release-notes.. how about > 'new-cookie' ? +1 Cookie description added! Would it make sense to have the "Add order" link a bit more visible? (In reply to Jonathan Druart from comment #16) > Would it make sense to have the "Add order" link a bit more visible? As you have to start from the basket I don't mind the current display - people will be looking for the link. But open to ideas, what were you thinking of? (In reply to Katrin Fischer from comment #17) > (In reply to Jonathan Druart from comment #16) > > Would it make sense to have the "Add order" link a bit more visible? > > As you have to start from the basket I don't mind the current display - > people will be looking for the link. But open to ideas, what were you > thinking of? To be honest I spent 10 min trying to understand which parameter was missing, and why the previous view (the table with the "Order" buttons on the right) did not appear. I thought it was a bug! If we are coming from the acquisition module we certainly only want to do that action, however the link is lost between all the other links. I do not have an idea that could be ergonomic however (I thought maybe cats, snow or stars around the new link? but...) (In reply to Jonathan Druart from comment #18) > (In reply to Katrin Fischer from comment #17) > > (In reply to Jonathan Druart from comment #16) > > > Would it make sense to have the "Add order" link a bit more visible? > > > > As you have to start from the basket I don't mind the current display - > > people will be looking for the link. But open to ideas, what were you > > thinking of? > > To be honest I spent 10 min trying to understand which parameter was > missing, and why the previous view (the table with the "Order" buttons on > the right) did not appear. I thought it was a bug! > If we are coming from the acquisition module we certainly only want to do > that action, however the link is lost between all the other links. > I do not have an idea that could be ergonomic however (I thought maybe cats, > snow or stars around the new link? but...) I think the inbuilt list for odering lacked some of the information that you would want to see. To me this works similar now than the 'search to hold' or 'order from holds ratio report' where we display an additional link, when the feature was activated. What could be nice is maybe displaying a 'back to basket' link where the 'last patron' thing is? Just thinking how we could further streamline navigation... New feature not backported to 19.11.x Did anyone sponsor this one? |