It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner.
Created attachment 95811 [details] [review] Bug 24111: Remove incorrect "Can't create any orders" alert It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner. Test plan: 0/ Add an owner to all of your funds 1/ Create an order from an existing record => Without this patch you should see the alert at the bottom of the result list => With this patch applied you should not see it QA will compare with the 2 other occurrences, in acqui/basket.pl and acqui/booksellers.pl
Hello, I cannot recreate the error message in the sandbox. I can recreate it in our own test Koha on version 19.05.04. Of course there can be differences in our setups. I have tried the sandbox both with and without the patch.
`error: sha1 information is lacking or useless (acqui/neworderbiblio.pl).`.. any chance of a rebase on this one Jonathan?
acqui/neworderbiblio.pl has been removed by bug 24347 and should have fixed the issue reported initially.