Prior to 20.05, when adding to a basket in acquisitions from an existing record, a search with no results left the user at /acqui/neworderbiblio.pl where they could then add to the basket via external source, etc. In 20.05 the user now ends at catalogue/search.pl and has to use the back button to return to the vendors list, and access the basket again.
Confirmed! We found this bug.
Created attachment 118126 [details] [review] Bug 27900: Add a link back to the basket view if no result Since bug 24347 the neworderbiblio view has been removed and we now display the usual search result. When adding a new order from a search, if there is no result we should let the user get back to the basket view. Test plan: Add to basket from an existing record Do a search with no results and confirm that there is a new "Go to the basket view" link
Does this patch meet your needs?
Created attachment 119107 [details] [review] Bug 27900: Add a link back to the basket view if no result Since bug 24347 the neworderbiblio view has been removed and we now display the usual search result. When adding a new order from a search, if there is no result we should let the user get back to the basket view. Test plan: Add to basket from an existing record Do a search with no results and confirm that there is a new "Go to the basket view" link Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
I never noticed that problem, nice catch Donna, and thank you Jonathan for fixing it, to me it works fine !
Created attachment 119133 [details] [review] Bug 27900: Add a link back to the basket view if no result Since bug 24347 the neworderbiblio view has been removed and we now display the usual search result. When adding a new order from a search, if there is no result we should let the user get back to the basket view. Test plan: Add to basket from an existing record Do a search with no results and confirm that there is a new "Go to the basket view" link Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 119134 [details] [review] Bug 27900: (QA follow-up) Add missing filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 119135 [details] [review] Bug 27900: (QA follow-up) Rephrase link text See discussion on IRC from today :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Are we able to get this ported back to 20.05?
Pushed to 20.05.x for 20.05.11
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.