| Summary: | OPAC account page no longer asks for confirmation before deleting hold | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, maryse.simard, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21772, 24341 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24433: OPAC account page no longer asks for confirmation before deleting hold
Bug 24433: OPAC account page no longer asks for confirmation before deleting hold Bug 24433: OPAC account page no longer asks for confirmation before deleting hold |
||
|
Description
Owen Leonard
2020-01-16 14:15:15 UTC
Created attachment 97445 [details] [review] Bug 24433: OPAC account page no longer asks for confirmation before deleting hold This patch restores markup added by Bug 21870 and subsequently removed accidentally by Bug 21772. This allows the OPAC user summary page to display a confirmation dialog before deleting a hold. To test, apply the patch and log in to the OPAC as a user with holds. - On the "Your summary" page, click the "Holds" tab. - Click the "Cancel" button next to any hold. - You should see a modal dialog asking for confirmation, showing the correct title. - Test both the "Yes" and "No" actions. Created attachment 97570 [details] [review] Bug 24433: OPAC account page no longer asks for confirmation before deleting hold This patch restores markup added by Bug 21870 and subsequently removed accidentally by Bug 21772. This allows the OPAC user summary page to display a confirmation dialog before deleting a hold. To test, apply the patch and log in to the OPAC as a user with holds. - On the "Your summary" page, click the "Holds" tab. - Click the "Cancel" button next to any hold. - You should see a modal dialog asking for confirmation, showing the correct title. - Test both the "Yes" and "No" actions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 97592 [details] [review] Bug 24433: OPAC account page no longer asks for confirmation before deleting hold This patch restores markup added by Bug 21870 and subsequently removed accidentally by Bug 21772. This allows the OPAC user summary page to display a confirmation dialog before deleting a hold. To test, apply the patch and log in to the OPAC as a user with holds. - On the "Your summary" page, click the "Holds" tab. - Click the "Cancel" button next to any hold. - You should see a modal dialog asking for confirmation, showing the correct title. - Test both the "Yes" and "No" actions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=24341 Nice work everyone! Pushed to master for 20.05 *** Bug 24095 has been marked as a duplicate of this bug. *** Not backported to 19.11.x due to dependencies |