Bug 25515

Summary: [OMNIBUS] Remove warnings and errors from tests output
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Chris Cormack <chris>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: m.de.rooy, martin.renvoize, mtj
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 18772, 26186, 34697, 34838, 36919, 36923, 36924, 36936, 36937, 36938, 36939, 38944, 26157, 26417, 26892, 28483, 29273, 29315, 30731, 36356, 36917, 36918, 36935    
Bug Blocks:    

Description Jonathan Druart 2020-05-15 13:40:43 UTC
We have tons of:

"Use of uninitialized value"
"DBIx::Class::Storage::DBI::_dbh_execute():"
"Subroutine * redefined"
"Argument "" isn't numeric in numeric"

We must get rid of them and provide a clean output.
Comment 1 Jonathan Druart 2020-08-06 11:04:17 UTC
Bug 26157 - Redirect expected DBI warnings

is going to deal with "DBIx::Class::Storage::DBI::_dbh_execute():"
Comment 2 Jonathan Druart 2020-08-10 08:33:45 UTC
Bug 26186 - Remove "subroutine redefined" warnings from tests
Comment 3 Jonathan Druart 2020-12-02 10:57:11 UTC
*** Bug 8879 has been marked as a duplicate of this bug. ***
Comment 4 Marcel de Rooy 2022-05-19 06:20:59 UTC
Bug 30731 removes a few too.
I removed the keyword for 22.05 here, no patches here. Just an omnibus.
Comment 5 Martin Renvoize (ashimema) 2024-06-27 08:56:09 UTC
I wonder if adding Test::NoWarnings might be worthwhile in out test scripts... then a warning is actually a test fail.
Comment 6 Jonathan Druart 2024-07-10 14:08:56 UTC
(In reply to Martin Renvoize from comment #5)
> I wonder if adding Test::NoWarnings might be worthwhile in out test
> scripts... then a warning is actually a test fail.

I always wanted to reach a point where no warnings where generated by the test suite and then we could add a test to parse the whole output and catch warnings. Looks like a never-ending process.

Using Test::NoWarnings on the tests not generating warnings now sounds like a good idea!
Comment 7 Jonathan Druart 2025-01-22 13:46:05 UTC
Added a patch on bug 38944.