Run about. CHeck your staff log. [2022/05/11 13:40:29] [WARN] Subroutine CORE::GLOBAL::time redefined at /usr/share/perl5/Test/MockTime.pm line 20, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Prototype mismatch: sub CORE::GLOBAL::time () vs none at /usr/share/perl5/Test/MockTime.pm line 20, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Subroutine CORE::GLOBAL::localtime redefined at /usr/share/perl5/Test/MockTime.pm line 21, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Prototype mismatch: sub CORE::GLOBAL::localtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 21, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Subroutine CORE::GLOBAL::gmtime redefined at /usr/share/perl5/Test/MockTime.pm line 22, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Prototype mismatch: sub CORE::GLOBAL::gmtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 22, <DATA> line 755.
The changes from the change of PerlDependencies to cpanfile make the Readonly::XS::MAGIC_COOKIE no longer needed too. See also bug 20103.
Created attachment 134913 [details] [review] Bug 30731: Unit tests Installer_pm.t can safely be discarded, having Installer_PerlModules.t. Note: Without the second patch, the test about versions_info being silent might fail. With the second patch, it should pass. Note that since the order of requiring the cpan modules varies (without the second patch), the results (potential warnings) vary too. Test plan: Run t/Installer_PerlModules.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 134914 [details] [review] Bug 30731: Silence noisy CPAN modules in C4::Installer::PerlModules Main change is replacing 'no warnings' by local $SIG{__WARN__}. The modules are sorted now too. This will make results of requiring them one after the other a more predictable experience and improves the output of koha_perl_deps. Test plan: Run about. Check plack intranet log. Run koha_perl_deps.pl -a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 134915 [details] [review] Bug 30731: Remove Readonly::XS::MAGIC_COOKIE This variable does not make sense anymore, since the Readonly::XS module is not listed in the cpanfile. So it will not be required the versions_info loop. Test plan: Run t/Installer_PerlModules.t again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 134917 [details] [review] Bug 30731: Unit tests Installer_pm.t can safely be discarded, having Installer_PerlModules.t. Note: Without the second patch, the test about versions_info being silent might fail. With the second patch, it should pass. Note that since the order of requiring the cpan modules varies (without the second patch), the results (potential warnings) vary too. Test plan: Run t/Installer_PerlModules.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 134918 [details] [review] Bug 30731: Silence noisy CPAN modules in C4::Installer::PerlModules Main change is replacing 'no warnings' by local $SIG{__WARN__}. The modules are sorted now too. This will make results of requiring them one after the other a more predictable experience and improves the output of koha_perl_deps. Test plan: Run about. Check plack intranet log. Run koha_perl_deps.pl -a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 134919 [details] [review] Bug 30731: Remove Readonly::XS::MAGIC_COOKIE This variable does not make sense anymore, since the Readonly::XS module is not listed in the cpanfile. So it will not be required the versions_info loop. Test plan: Run t/Installer_PerlModules.t again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Looking here now.
Created attachment 134960 [details] [review] Bug 30731: Unit tests Installer_pm.t can safely be discarded, having Installer_PerlModules.t. Note: Without the second patch, the test about versions_info being silent might fail. With the second patch, it should pass. Note that since the order of requiring the cpan modules varies (without the second patch), the results (potential warnings) vary too. Test plan: Run t/Installer_PerlModules.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 134961 [details] [review] Bug 30731: Silence noisy CPAN modules in C4::Installer::PerlModules Main change is replacing 'no warnings' by local $SIG{__WARN__}. The modules are sorted now too. This will make results of requiring them one after the other a more predictable experience and improves the output of koha_perl_deps. Test plan: Run about. Check plack intranet log. Run koha_perl_deps.pl -a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 134962 [details] [review] Bug 30731: Remove Readonly::XS::MAGIC_COOKIE This variable does not make sense anymore, since the Readonly::XS module is not listed in the cpanfile. So it will not be required the versions_info loop. Test plan: Run t/Installer_PerlModules.t again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
I prefer not to push in this release
(In reply to Fridolin Somers from comment #12) > I prefer not to push in this release 21.11 => 22.11
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
thx, pushed to 21.11.x for 21.11.07
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.