Bug 26186 - Remove "subroutine redefined" warnings from tests
Summary: Remove "subroutine redefined" warnings from tests
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 25515
  Show dependency treegraph
 
Reported: 2020-08-10 08:32 UTC by Jonathan Druart
Modified: 2023-09-26 10:21 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26186: remove 'subroutine redefined' warnings in Auth_with_ldap.t (948 bytes, patch)
2020-08-10 08:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2020-08-10 08:32:18 UTC
kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/cronjobs/advance_notices_digest.t
t/db_dependent/cronjobs/advance_notices_digest.t .. No circulation PREDUEDGST letter transported by phone at /kohadevbox/koha/C4/Letters.pm line 605.
Use of uninitialized value in concatenation (.) or string at (eval 1565) line 587.
no letter of type '' found for borrowernumber 58. Please see sample_notices.sql at (eval 1565) line 587.
t/db_dependent/cronjobs/advance_notices_digest.t .. 1/2 Subroutine parse_letter redefined at (eval 1572) line 444.
Subroutine get_branch_info redefined at (eval 1572) line 481.
Subroutine send_digests redefined at (eval 1572) line 532.
No circulation PREDUEDGST letter transported by phone at /kohadevbox/koha/C4/Letters.pm line 605.
Use of uninitialized value in concatenation (.) or string at (eval 1572) line 587.
no letter of type '' found for borrowernumber 59. Please see sample_notices.sql at (eval 1572) line 587.
No circulation PREDUEDGST letter transported by phone at /kohadevbox/koha/C4/Letters.pm line 605.
Use of uninitialized value in concatenation (.) or string at (eval 1572) line 587.
no letter of type '' found for borrowernumber 59. Please see sample_notices.sql at (eval 1572) line 587.
t/db_dependent/cronjobs/advance_notices_digest.t .. ok   
All tests successful.
Files=1, Tests=2,  5 wallclock secs ( 0.02 usr  0.01 sys +  3.34 cusr  1.38 csys =  4.75 CPU)
Result: PASS





kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Auth_with_ldap.t              
t/db_dependent/Auth_with_ldap.t .. 1/4 Subroutine ldapserver_error redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 48.
Subroutine description redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 80.              
Subroutine search_method redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 87.                                                                                                                               
Subroutine checkpw_ldap redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 111.
Subroutine ldap_entry_2_hash redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 261.               
Subroutine exists_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 312.                                                                                                                               
Subroutine _do_changepassword redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 338.
Subroutine update_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 369.
Subroutine ldapserver_error redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 48.          
Subroutine description redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 80.
Subroutine search_method redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 87.                    
Subroutine checkpw_ldap redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 111.             
Subroutine ldap_entry_2_hash redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 261.
Subroutine exists_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 312.                    
Subroutine _do_changepassword redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 338.
Subroutine update_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 369.
Comment 1 Jonathan Druart 2020-08-10 08:33:07 UTC
Created attachment 107983 [details] [review]
Bug 26186: remove 'subroutine redefined' warnings in Auth_with_ldap.t
Comment 2 Katrin Fischer 2023-09-22 19:31:35 UTC
Still valid - can the patch be tested?
Comment 3 Jonathan Druart 2023-09-26 10:21:56 UTC
The patch is about Auth_with_ldap.t, and I am not getting warnings from this script anymore.