| Summary: | Add street type to alternate address in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | corinne.hayet, fridolin.somers, kyle, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.02
|
|
| Circulation function: | |||
| Bug Depends on: | 18112 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28313: Add street type to alternate address in OPAC
Bug 28313: Add street type to alternate address in OPAC Bug 28313: Add street type to alternate address in OPAC Bug 28313: (follow-up) Define roadtypes |
||
|
Description
Katrin Fischer
2021-05-10 20:48:11 UTC
Created attachment 120813 [details] [review] Bug 28313: Add street type to alternate address in OPAC 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure B_streettype is NOT checked 3. Go the self reg form, no alternate address street type field 4. Apply patch 5. Check the self reg form, B_streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, B_street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. That was pretty quick! Created attachment 120919 [details] [review] Bug 28313: Add street type to alternate address in OPAC 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure B_streettype is NOT checked 3. Go the self reg form, no alternate address street type field 4. Apply patch 5. Check the self reg form, B_streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, B_street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: David Nind <david@davidnind.com> This includes strings, so probably will have to wait until after release. Created attachment 121592 [details] [review] Bug 28313: Add street type to alternate address in OPAC 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure B_streettype is NOT checked 3. Go the self reg form, no alternate address street type field 4. Apply patch 5. Check the self reg form, B_streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, B_street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 12936 has been marked as a duplicate of this bug. *** Created attachment 122213 [details] [review] Bug 28313: (follow-up) Define roadtypes It's not necessarily defined at this point Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.02 Not pushed to 20.11.x since Bug 18112 is not |