streettype is missing in opac-memberentry.pl, we cannot have a complete address
I confirm that this is still the case in master
streettype is also missing on memberentrygen.tt yet it exists as an option on BorrowerMandatoryField and PatronSelfRegistrationBorrowerMandatoryField. If you add street type to either of these system preference you can never complete the form.
(In reply to Lucas Gass from comment #2) > streettype is also missing on memberentrygen.tt yet it exists as an option > on BorrowerMandatoryField and PatronSelfRegistrationBorrowerMandatoryField. > > If you add street type to either of these system preference you can never > complete the form. I am mistaken. Streettype will appear on memberentrygen.tt IF the AV ROADTYPE contains values. It is missing from the OPAC.
Created attachment 120476 [details] [review] Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required.
This works as expected except for one thing: A required street type <select> is not caught by the client-side validation. In the template the tag is missing "class="[% required.streettype | html %]"
Created attachment 120720 [details] [review] Bug 18112: (follow-up) add required class to select
Created attachment 120770 [details] [review] Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120771 [details] [review] Bug 18112: (follow-up) add required class to select Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I think this is a needed change and I don't want to block it. But should we not open a new bug for adding the street type to alternate address as well to match the staff side?
Created attachment 120809 [details] [review] Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 120810 [details] [review] Bug 18112: (follow-up) add required class to select Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 120841 [details] [review] Bug 18112: Use GetAuthValueDropbox from the template
Pushed to master for 21.05, thanks to everybody involved!
Does not apply on 20.11.x. Please provide patches if needed.