Summary: | OMNIBUS: Replace the use of jQueryUI | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, dcook, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 34113, 34270, 29224, 29226, 32969, 34114 | ||
Bug Blocks: |
Description
Owen Leonard
2021-10-13 15:13:06 UTC
(In reply to Owen Leonard from comment #0) > - Accordion .. > - OPAC Sorry this was incomplete. The OPAC doesn't use jQueryUI accordion. The other instance is Tools -> Notices. (In reply to Owen Leonard from comment #0) > jQueryUI is no longer being developed: > https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/ > > "our goal is to move it more to a maintenance state: we’ll make sure the > library is compatible with new jQuery releases and that security issues are > fixed but no new significant feature work is planned." > That's a bit of a let down after Michal previously made it seem like he was going to resurrect it, but good to know the outcome at least. +1 to replacing jQuery UI. (jQuery in general seems to have fallen out of favour in the tech world, so sometimes I wonder how long until we're replacing that too...) (In reply to Owen Leonard from comment #0) > No Bootstrap option. Possible candidate: > https://tarekraafat.github.io/autoComplete.js/. [Adding this here, to keep track of it] I've tried https://github.com/xcash/bootstrap-autocomplete, which seems to work well, but it does not with bootstrap 3 (no longer supported by the author) I've almost managed to deal with the different problem, but we will certainly need to build our own js file. First I had to pick the this fix: https://github.com/xcash/bootstrap-autocomplete/pull/129 or the drodown is empty with bootstrap 3 Then I faced https://github.com/xcash/bootstrap-autocomplete/issues/103 which appears to be fixed, but it's not (or not for bootstrap 3, I don't know). It's sad because I am almost there, but I lost confidence in this lib. Can be tested on https://gitlab.com/joubu/Koha/-/commits/bootstrap-autocomplete using the patron search autocomplete in the header. I've also tried https://tarekraafat.github.io/autoComplete.js but there was too much existing styling and I gave up quickly. |