Bug 34270 - Upgrade and prune jQueryUI assets in the staff interface
Summary: Upgrade and prune jQueryUI assets in the staff interface
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 33747 35046 (view as bug list)
Depends on: 34114
Blocks: 29222
  Show dependency treegraph
 
Reported: 2023-07-13 13:49 UTC by Owen Leonard
Modified: 2024-11-14 20:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:


Attachments
Bug 34270: Upgrade and prune jQueryUI assets in the staff interface (264.18 KB, patch)
2023-07-13 14:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34270: Upgrade and prune jQueryUI assets in the staff interface (264.34 KB, patch)
2023-09-12 15:48 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 34270: Upgrade and prune jQueryUI assets in the staff interface (264.40 KB, patch)
2023-10-07 17:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-13 13:49:56 UTC
With the elimination of our dependency on jQueryUI Sortable by Bug 34114 we will be left with only autocomplete as a jQueryUI dependency. We can trim down our jQueryUI assets to reflect this and upgrade at the same time.
Comment 1 Jonathan Druart 2023-07-13 13:55:18 UTC
Why not remove autocomplete as well? :)
Comment 2 Owen Leonard 2023-07-13 14:05:50 UTC
Created attachment 153398 [details] [review]
Bug 34270: Upgrade and prune jQueryUI assets in the staff interface

This patch updates jQueryUI assets in the staff interface with an
upgraded and trimmed version which includes only support for jQueryUI
autocomplete.

Global staff interface CSS has been modified to remove unused
jQueryUI-related styles and to accommodate the updated assets.

The patch also removes some unused jQueryUI image assets from the OPAC
templates.

To test, apply the patch and rebuild the staff interface CSS. Test the
"Check out" form in the header to confirm that it still looks correct
and works correctly.
Comment 3 Owen Leonard 2023-07-13 14:06:43 UTC
*** Bug 33747 has been marked as a duplicate of this bug. ***
Comment 4 Emily-Rose Francoeur 2023-09-12 15:48:08 UTC
Created attachment 155560 [details] [review]
Bug 34270: Upgrade and prune jQueryUI assets in the staff interface

This patch updates jQueryUI assets in the staff interface with an
upgraded and trimmed version which includes only support for jQueryUI
autocomplete.

Global staff interface CSS has been modified to remove unused
jQueryUI-related styles and to accommodate the updated assets.

The patch also removes some unused jQueryUI image assets from the OPAC
templates.

To test, apply the patch and rebuild the staff interface CSS. Test the
"Check out" form in the header to confirm that it still looks correct
and works correctly.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 5 Katrin Fischer 2023-10-07 17:50:41 UTC
Created attachment 156690 [details] [review]
Bug 34270: Upgrade and prune jQueryUI assets in the staff interface

This patch updates jQueryUI assets in the staff interface with an
upgraded and trimmed version which includes only support for jQueryUI
autocomplete.

Global staff interface CSS has been modified to remove unused
jQueryUI-related styles and to accommodate the updated assets.

The patch also removes some unused jQueryUI image assets from the OPAC
templates.

To test, apply the patch and rebuild the staff interface CSS. Test the
"Check out" form in the header to confirm that it still looks correct
and works correctly.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-10-09 14:42:53 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-09 18:46:19 UTC
Depends on Bug 34114 not in 23.05.x
Comment 8 Jonathan Druart 2024-03-14 14:53:56 UTC
*** Bug 35046 has been marked as a duplicate of this bug. ***