Bug 29222 - OMNIBUS: Replace the use of jQueryUI
Summary: OMNIBUS: Replace the use of jQueryUI
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 34113 34270 29224 29226 32969 34114
Blocks:
  Show dependency treegraph
 
Reported: 2021-10-13 15:13 UTC by Owen Leonard
Modified: 2023-07-13 14:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2021-10-13 15:13:06 UTC
jQueryUI is no longer being developed: https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/

"our goal is to move it more to a maintenance state: we’ll make sure the library is compatible with new jQuery releases and that security issues are fixed but no new significant feature work is planned."

I would like to start replacing jQueryUI dependencies, especially where there is a Bootstrap component which matches.

- Accordion
  - Administration -> Table settings
  - Patrons -> Patrons requesting modifications
  - OPAC

Can be replaced with Bootstrap "Collapse" component.

- Autocomplete
  - Checkout and patron header searches
  - Article request patron search
  - Course reserve instructor search
  - Holds patron search
  - UNIMARC 210c plugin
  - UNIMARC 225a plugin

No Bootstrap option. Possible candidate: https://tarekraafat.github.io/autoComplete.js/.

- Tabs
  - (Lots)

Can be replaced with Bootstrap tabs.

- Sortable
  - Administration -> MARC frameworks -> Subfield structure -> Tab reordering.
  - Administration -> Authority types -> Subfield structure -> Tab reordering.
  - Administration -> System preferences -> Language and OPACLanguage reordering
  - Cataloging -> Basic MARC editor -> Subfield reordering.
  - Tools -> Stock rotation -> Stage reordering.

No Bootstrap option.
Comment 1 Owen Leonard 2021-10-13 15:19:44 UTC
(In reply to Owen Leonard from comment #0)

> - Accordion
..
>   - OPAC

Sorry this was incomplete. The OPAC doesn't use jQueryUI accordion. The other instance is Tools -> Notices.
Comment 2 David Cook 2022-01-24 04:24:43 UTC
(In reply to Owen Leonard from comment #0)
> jQueryUI is no longer being developed:
> https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/
> 
> "our goal is to move it more to a maintenance state: we’ll make sure the
> library is compatible with new jQuery releases and that security issues are
> fixed but no new significant feature work is planned."
> 

That's a bit of a let down after Michal previously made it seem like he was going to resurrect it, but good to know the outcome at least.

+1 to replacing jQuery UI. 

(jQuery in general seems to have fallen out of favour in the tech world, so sometimes I wonder how long until we're replacing that too...)
Comment 3 Jonathan Druart 2022-11-23 09:28:01 UTC
(In reply to Owen Leonard from comment #0)
> No Bootstrap option. Possible candidate:
> https://tarekraafat.github.io/autoComplete.js/.

[Adding this here, to keep track of it]
I've tried https://github.com/xcash/bootstrap-autocomplete, which seems to work well, but it does not with bootstrap 3 (no longer supported by the author)
I've almost managed to deal with the different problem, but we will certainly need to build our own js file.

First I had to pick the this fix: https://github.com/xcash/bootstrap-autocomplete/pull/129 or the drodown is empty with bootstrap 3

Then I faced https://github.com/xcash/bootstrap-autocomplete/issues/103 which appears to be fixed, but it's not (or not for bootstrap 3, I don't know).

It's sad because I am almost there, but I lost confidence in this lib.

Can be tested on https://gitlab.com/joubu/Koha/-/commits/bootstrap-autocomplete
using the patron search autocomplete in the header.
Comment 4 Jonathan Druart 2022-11-23 09:28:51 UTC
I've also tried https://tarekraafat.github.io/autoComplete.js but there was too much existing styling and I gave up quickly.