As discussed in Bug 29222, jQueryUI sortable should be replaced. The last time I checked it was used in these places: - Administration -> MARC frameworks -> Subfield structure -> Tab reordering. - Administration -> Authority types -> Subfield structure -> Tab reordering. - Administration -> System preferences -> Language and OPACLanguage reordering - Cataloging -> Basic MARC editor -> Subfield reordering. - Tools -> Stock rotation -> Stage reordering. It looks like Drupal switched to this library: https://github.com/SortableJS/Sortable
Created attachment 153041 [details] [review] Bug 34114: Quick test with Sortable
This is working very easily and the doc is great. Good catch, Owen!
Created attachment 153395 [details] [review] Bug 34114: Replace the use of jQueryUI sortable This patch adds a replacement for jQueryUI sortable, a standalone library called Sortable. The patch updates pages which previously used jQueryUI for sorting. The patch updates the style of most sortable elements to use the "grip-vertical" Font Awesome icon. To test, apply the patch and test the following pages, confirming that sortable elements are sortable and that the newly sorted state is saved correctly: - Administration -> System prefernces -> I18N/L10N - With multiple languages installed, test that languages listed in the 'language' and 'OPACLanguages' preferences can be sorted and that after saving your changes the interface relfects your changes: In the footer and header of the OPAC and in the footer of the staff interface. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields of a tag. - Test using a tag with multiple subfields, e.g. MARC21 245. - Test that you can click and drag to reorder the tabs in the subfield edit view. - Test that when you save your changes, including changes to the "New" tab position, that fields are ordered correctly both in the display on this page and in the basic MARC editor. - Perform the same tests on Authorities: Administration -> Authority types -> MARC structure -> Edit subfields of a tag. - Authorities -> New (or edit) authority - Multiple subfields of a tag should be sortable. - Multiple copies of the same tag should be sortable relative to each other. - Confirm that your changes are saved correctly and that the detail view of your updated authority record is correct. - Perform the same tests on Cataloging -> New (or edit) record in the basic MARC editor. - Enable the StockRotation system preference if necessary. - Go to Cataloging -> Stock rotation - If necessary, create a new rota and add multiple stages - In the "Manage stages" view you should be able to click and drag to reorder stages. The new position should be saved immediately via AJAX.
Created attachment 154626 [details] [review] Bug 34114: Replace the use of jQueryUI sortable This patch adds a replacement for jQueryUI sortable, a standalone library called Sortable. The patch updates pages which previously used jQueryUI for sorting. The patch updates the style of most sortable elements to use the "grip-vertical" Font Awesome icon. To test, apply the patch and test the following pages, confirming that sortable elements are sortable and that the newly sorted state is saved correctly: - Administration -> System prefernces -> I18N/L10N - With multiple languages installed, test that languages listed in the 'language' and 'OPACLanguages' preferences can be sorted and that after saving your changes the interface relfects your changes: In the footer and header of the OPAC and in the footer of the staff interface. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields of a tag. - Test using a tag with multiple subfields, e.g. MARC21 245. - Test that you can click and drag to reorder the tabs in the subfield edit view. - Test that when you save your changes, including changes to the "New" tab position, that fields are ordered correctly both in the display on this page and in the basic MARC editor. - Perform the same tests on Authorities: Administration -> Authority types -> MARC structure -> Edit subfields of a tag. - Authorities -> New (or edit) authority - Multiple subfields of a tag should be sortable. - Multiple copies of the same tag should be sortable relative to each other. - Confirm that your changes are saved correctly and that the detail view of your updated authority record is correct. - Perform the same tests on Cataloging -> New (or edit) record in the basic MARC editor. - Enable the StockRotation system preference if necessary. - Go to Cataloging -> Stock rotation - If necessary, create a new rota and add multiple stages - In the "Manage stages" view you should be able to click and drag to reorder stages. The new position should be saved immediately via AJAX. Signed-off-by: paul <paul.poulain@biblibre.com>
Created attachment 155008 [details] [review] Bug 34114: Replace the use of jQueryUI sortable This patch adds a replacement for jQueryUI sortable, a standalone library called Sortable. The patch updates pages which previously used jQueryUI for sorting. The patch updates the style of most sortable elements to use the "grip-vertical" Font Awesome icon. To test, apply the patch and test the following pages, confirming that sortable elements are sortable and that the newly sorted state is saved correctly: - Administration -> System prefernces -> I18N/L10N - With multiple languages installed, test that languages listed in the 'language' and 'OPACLanguages' preferences can be sorted and that after saving your changes the interface relfects your changes: In the footer and header of the OPAC and in the footer of the staff interface. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields of a tag. - Test using a tag with multiple subfields, e.g. MARC21 245. - Test that you can click and drag to reorder the tabs in the subfield edit view. - Test that when you save your changes, including changes to the "New" tab position, that fields are ordered correctly both in the display on this page and in the basic MARC editor. - Perform the same tests on Authorities: Administration -> Authority types -> MARC structure -> Edit subfields of a tag. - Authorities -> New (or edit) authority - Multiple subfields of a tag should be sortable. - Multiple copies of the same tag should be sortable relative to each other. - Confirm that your changes are saved correctly and that the detail view of your updated authority record is correct. - Perform the same tests on Cataloging -> New (or edit) record in the basic MARC editor. - Enable the StockRotation system preference if necessary. - Go to Cataloging -> Stock rotation - If necessary, create a new rota and add multiple stages - In the "Manage stages" view you should be able to click and drag to reorder stages. The new position should be saved immediately via AJAX. Signed-off-by: paul <paul.poulain@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x