Summary: | "Replace existing covers" checkbox replaces ALL local covers for a biblio, not only the specific item's covers | ||
---|---|---|---|
Product: | Koha | Reporter: | Manos PETRIDIS <egpetridis> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | arthur.suzuki, egpetridis, jonathan.druart, lucas, m.de.rooy, oleonard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.01
|
|
Circulation function: | |||
Bug Depends on: | 30234 | ||
Bug Blocks: | |||
Attachments: |
Bug 30972: Don't replace biblio's local cover images when uploading an image's image
Bug 30972: Don't replace biblio's local cover images when uploading an image's image Bug 30972: Don't replace biblio's local cover images when uploading an image's image |
Description
Manos PETRIDIS
2022-06-16 07:36:56 UTC
Are talking about cover images you attached to an *item* (vs bibliographic record)? This feature has been added by bug 26145 and is not in Koha "for years" ;) Created attachment 136145 [details] [review] Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Created attachment 136160 [details] [review] Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Signed-off-by: David Nind <david@davidnind.com> (In reply to Jonathan Druart from comment #1) > Are talking about cover images you attached to an *item* (vs bibliographic > record)? > This feature has been added by bug 26145 and is not in Koha "for years" ;) Well, if left unresolved, it could very well ruin many a years' work in the future ;) Created attachment 136322 [details] [review] Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.01 I don't reproduce the issue on 21.11.x. not backporting :) |