It seems that the "Replace existing covers" checkbox in /cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=2385&filetype=image# now replaces ALL covers for a biblio, not only the specific item's cover(s). This is a departure from how koha worked in the past, is undocumented and could become a major problem for libraries keeping Continuing Resources local cover images, discarding years' work in an instance. When one uploads a cover for a specific issue, replace should work for only the cover(s) linked to that specific issue. The problem may also be related to issue cover images now appearing as alternate cover images for the biblio. In the past if one wanted the biblio to have a cover image attached, one had to upload an image to the biblio itself.
Are talking about cover images you attached to an *item* (vs bibliographic record)? This feature has been added by bug 26145 and is not in Koha "for years" ;)
Created attachment 136145 [details] [review] Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio
Created attachment 136160 [details] [review] Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Signed-off-by: David Nind <david@davidnind.com>
(In reply to Jonathan Druart from comment #1) > Are talking about cover images you attached to an *item* (vs bibliographic > record)? > This feature has been added by bug 26145 and is not in Koha "for years" ;) Well, if left unresolved, it could very well ruin many a years' work in the future ;)
Created attachment 136322 [details] [review] Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.01
I don't reproduce the issue on 21.11.x. not backporting :)