Created attachment 131397 [details] Administrative view. I'm running koha v21.11.03.000 and I've noticed that serial covers no longer appear in the administrative interface. They do appear in OPAC nevertheless.
Created attachment 131398 [details] OPAC view
Created attachment 131399 [details] Columns available in administrative interface.
Created attachment 131400 [details] Search preferences
Created attachment 131401 [details] Serials preferences
Created attachment 131402 [details] Cover preferences
Must clarify that older local cover images do appear. Same goes for new images added to new items/issues of older records/serials.
You don't give information of where you pull the images from. On item level we can only display local covers, but your screenshot of the system preferences shows that you have turned that feature off?
(In reply to Katrin Fischer from comment #7) > You don't give information of where you pull the images from. > > On item level we can only display local covers, but your screenshot of the > system preferences shows that you have turned that feature off? Images are from the same server that exhibits this problem. Please note that in 'Cover preferences' attachment both LocalCoverImages and OPACLocalCoverImages are set to Display. i.e. they're enabled. Otherwhise no local cover images would be displayed at all. Please also note that: * Older biblios display all items' images in the administrative interface, even those I added today. Note biblionumber 642 in '202203_642_Admin' * Newer biblios don't display any items' images in the administrative interface. Note biblionumber 1234 in '202203_NatGeo_Admin' * Newer biblios do display all items' images in OPAC. Note biblionumber 1234 for example in '202203_NatGeo_OPAC'
Created attachment 131418 [details] Newer biblios don't display any items' images in the administrative interface.
Created attachment 131419 [details] Newer biblios do display all items' images in OPAC.
Created attachment 131420 [details] Older biblios display all items' images in the administrative interface, even those I added today.
Using v21.11.03: 0. turned the prefs on 1. created a new bibliographic record 2. attached a cover image to the bib record 3. created a new item 4. attached a cover image to the item => I see the cover images on the staff interface. Do you see an error in the console? Please try to recreate the problem on a sandbox and provide us the different steps.
(In reply to Jonathan Druart from comment #12) > Using v21.11.03: > 0. turned the prefs on > 1. created a new bibliographic record > 2. attached a cover image to the bib record > 3. created a new item > 4. attached a cover image to the item > > => I see the cover images on the staff interface. > > Do you see an error in the console? > Please try to recreate the problem on a sandbox and provide us the different > steps. No errors in the browser console. How might I load my library's backup to a sandbox? The issue does not always appear, therefore any new additions might not bring it to the surface. Menawhile however, I've discovered what the issue is: Local covers are displayed in the administrative interface only for the items set as having home library the one selected by the user upon entry / set my the user using the selector in the upper right corner.
ok, I recreate now, with SeparateHoldings. It seems broken since attaching a cover images to items is possible.
Created attachment 131430 [details] [review] Bug 30234: Fix local cover image display for other holdings Bug 26145 added the ability to add local cover images to items. If SeparateHoldings is set, items from other libraries are displayed in a separate tab, and not considered as visible. We have a JS test to assume that images not shown are not present, this only apply for the images for the bibliographic record, as they can come from different sources. Test plan: Turn on LocalCoverImages and SeparateHoldings Create a record with different items coming from different libraries Attach images to items and to the biblio Notice that with this patch you can see the images from the "Other holdings" tab
Hum I found a bug but it's not exactly what you are describing. Can you try the patch and see if it fixes your problem?
(In reply to Jonathan Druart from comment #16) > Hum I found a bug but it's not exactly what you are describing. Can you try > the patch and see if it fixes your problem? My installation is a packages one, but I can verify that by updating file /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/catalogue/detail.tt issue has been resolved. I notice that there are several similar files, for different interface languages, for example /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/el-GR/modules/catalogue/detail.tt These files be automatically updated I suppose once the fix reaches some future release. MP
(In reply to Jonathan Druart from comment #16) > Hum I found a bug but it's not exactly what you are describing. Can you try > the patch and see if it fixes your problem? Jonathan, your fix seems similar to the problem describe in Bug 30792. Do you think these are duplicate issues?
(In reply to Lucas Gass from comment #18) > (In reply to Jonathan Druart from comment #16) > > Hum I found a bug but it's not exactly what you are describing. Can you try > > the patch and see if it fixes your problem? > > Jonathan, your fix seems similar to the problem describe in Bug 30792. Do > you think these are duplicate issues? Looks like, yes.
*** Bug 30792 has been marked as a duplicate of this bug. ***
Created attachment 136142 [details] [review] Bug 30234: Fix local cover image display for other holdings Bug 26145 added the ability to add local cover images to items. If SeparateHoldings is set, items from other libraries are displayed in a separate tab, and not considered as visible. We have a JS test to assume that images not shown are not present, this only apply for the images for the bibliographic record, as they can come from different sources. Test plan: Turn on LocalCoverImages and SeparateHoldings Create a record with different items coming from different libraries Attach images to items and to the biblio Notice that with this patch you can see the images from the "Other holdings" tab
Looks like without this patch we don't even see the cover images for the item in 'Holdings'. Upping severity.
Created attachment 136154 [details] [review] Bug 30234: Fix local cover image display for other holdings Bug 26145 added the ability to add local cover images to items. If SeparateHoldings is set, items from other libraries are displayed in a separate tab, and not considered as visible. We have a JS test to assume that images not shown are not present, this only apply for the images for the bibliographic record, as they can come from different sources. Test plan: Turn on LocalCoverImages and SeparateHoldings Create a record with different items coming from different libraries Attach images to items and to the biblio Notice that with this patch you can see the images from the "Other holdings" tab Signed-off-by: David Nind <david@davidnind.com>
Created attachment 136324 [details] [review] Bug 30234: Fix local cover image display for other holdings Bug 26145 added the ability to add local cover images to items. If SeparateHoldings is set, items from other libraries are displayed in a separate tab, and not considered as visible. We have a JS test to assume that images not shown are not present, this only apply for the images for the bibliographic record, as they can come from different sources. Test plan: Turn on LocalCoverImages and SeparateHoldings Create a record with different items coming from different libraries Attach images to items and to the biblio Notice that with this patch you can see the images from the "Other holdings" tab Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.01
patch fixes the issue on 21.11.x, pushed for 21.11.10
Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document, marking resolved.