Summary: | Add Koha::Biblio->normalized_isbn | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 33949, 33953 | ||
Attachments: |
Bug 33952: Add tests
Bug 33952: Koha::Biblio->normalized_isbn Bug 33952: Add tests Bug 33952: Koha::Biblio->normalized_isbn Bug 33952: Koha::Biblio->normalized_isbn Bug 33952: Add tests Bug 33952: Koha::Biblio->normalized_isbn |
Description
Jonathan Druart
2023-06-08 10:10:43 UTC
Created attachment 152146 [details] [review] Bug 33952: Add tests Created attachment 152147 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn to squash get_normalized_isbn Created attachment 152718 [details] [review] Bug 33952: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 152719 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn to squash get_normalized_isbn Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> At first thought, I'd love to have seen us not rely upon C4::Koha:: in here.. but when inspecting that code I decided we could drop that at a later date and let this move forward. Signing off Yes I should have added more context. This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object. Created attachment 153005 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 153409 [details] [review] Bug 33952: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 153410 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Not required for anything in 23.05.x series yet, we can backport later if it becomes required. |