33953 – Add Koha::Biblio->ratings

Bug 33953 - Add Koha::Biblio->ratings

Summary: Add Koha::Biblio->ratings

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:
Keywords:

Depends on:	33952
Blocks:	33949 33954
	Show dependency tree / graph

Reported:	2023-06-08 10:11 UTC by Jonathan Druart
Modified:	2024-07-04 20:37 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	23.11.00
Circulation function:

Attachments
Bug 33953: Adjust tests (2.80 KB, patch) 2023-06-08 10:55 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33953: Koha::Biblio->ratings (1.01 KB, patch) 2023-06-08 10:55 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33953: Adjust tests (2.86 KB, patch) 2023-06-27 10:28 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Bug 33953: Koha::Biblio->ratings (1.07 KB, patch) 2023-06-27 10:28 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Bug 33953: Adjust tests (2.91 KB, patch) 2023-07-13 16:08 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 33953: Koha::Biblio->ratings (1.13 KB, patch) 2023-07-13 16:08 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2023-06-08 10:11:19 UTC

Comment 1 Jonathan Druart 2023-06-08 10:55:53 UTC

Created attachment 152148 [details] [review]
Bug 33953: Adjust tests

Comment 2 Jonathan Druart 2023-06-08 10:55:55 UTC

Created attachment 152149 [details] [review]
Bug 33953: Koha::Biblio->ratings

Comment 3 Martin Renvoize (ashimema) 2023-06-27 10:28:26 UTC

Created attachment 152720 [details] [review]
Bug 33953: Adjust tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2023-06-27 10:28:29 UTC

Created attachment 152721 [details] [review]
Bug 33953: Koha::Biblio->ratings

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Martin Renvoize (ashimema) 2023-06-27 10:29:18 UTC

Great to see these relations being added.. going straight for a PQA here as it's a trivial patch and is working exactly as expected.

Passing QA

Comment 6 Tomás Cohen Arazi (tcohen) 2023-07-03 14:54:52 UTC

I'd like to push it, but depends on another (unrelated?) patchset.

Comment 7 Jonathan Druart 2023-07-04 07:34:15 UTC

(In reply to Tomás Cohen Arazi from comment #6)
> I'd like to push it, but depends on another (unrelated?) patchset.

It prevents a conflict on t/db_dependent/Koha/Biblio.t

Comment 8 Jonathan Druart 2023-07-04 07:37:48 UTC

This is needed for bug 33947 where we need to call ->ratings on a Koha::Biblio object.

Comment 9 Nick Clemens (kidclamp) 2023-07-13 16:08:04 UTC

Created attachment 153411 [details] [review]
Bug 33953: Adjust tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 10 Nick Clemens (kidclamp) 2023-07-13 16:08:06 UTC

Created attachment 153412 [details] [review]
Bug 33953: Koha::Biblio->ratings

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 11 Tomás Cohen Arazi (tcohen) 2023-07-13 18:21:31 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 12 Martin Renvoize (ashimema) 2023-07-18 11:28:31 UTC

Not required for anything in 23.05.x series yet, we can backport later if it becomes required.