| Summary: | opac-user.pl should use Koha::Biblio->opac_summary_html | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 33954 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl |
||
|
Description
Jonathan Druart
2023-06-08 10:47:57 UTC
Created attachment 153042 [details] [review] Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl. After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl. Final situation will be: we have the code in a module, covered by tests \o/ Test plan: Check an item out Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance) Go to the "Your summary" at the OPAC and notice the "Links" column Everything should work identically before and after this patch Created attachment 153074 [details] [review] Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl. After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl. Final situation will be: we have the code in a module, covered by tests \o/ Test plan: Check an item out Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance) Go to the "Your summary" at the OPAC and notice the "Links" column Everything should work identically before and after this patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 153415 [details] [review] Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl. After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl. Final situation will be: we have the code in a module, covered by tests \o/ Test plan: Check an item out Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance) Go to the "Your summary" at the OPAC and notice the "Links" column Everything should work identically before and after this patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Architectural enhancement, not required for 23.05.x series |