Bug 33956 - opac-user.pl should use Koha::Biblio->opac_summary_html
Summary: opac-user.pl should use Koha::Biblio->opac_summary_html
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33954
Blocks:
  Show dependency tree / graph
 
Reported: 2023-06-08 10:47 UTC by Jonathan Druart
Modified: 2024-07-04 20:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl (4.70 KB, patch)
2023-07-05 09:09 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl (4.75 KB, patch)
2023-07-05 17:24 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl (4.80 KB, patch)
2023-07-13 16:11 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 10:47:57 UTC 
Added by bug 33954
Comment 1 Jonathan Druart 2023-07-05 09:09:47 UTC 
Created attachment 153042 [details] [review]
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl

This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl.

After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl.

Final situation will be: we have the code in a module, covered by tests \o/

Test plan:
Check an item out
Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance)
Go to the "Your summary" at the OPAC and notice the "Links" column
Everything should work identically before and after this patch
Comment 2 Owen Leonard 2023-07-05 17:24:56 UTC 
Created attachment 153074 [details] [review]
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl

This code is currently duplicated in controllers opac-readingrecord.pl
and opac-user.pl.

After bug 33949 it will be removed from opac-readingrecord.pl, and bug
33956 aims to remove it from opac-user.pl.

Final situation will be: we have the code in a module, covered by tests
\o/

Test plan:
Check an item out
Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance)
Go to the "Your summary" at the OPAC and notice the "Links" column
Everything should work identically before and after this patch

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens (kidclamp) 2023-07-13 16:11:31 UTC 
Created attachment 153415 [details] [review]
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl

This code is currently duplicated in controllers opac-readingrecord.pl
and opac-user.pl.

After bug 33949 it will be removed from opac-readingrecord.pl, and bug
33956 aims to remove it from opac-user.pl.

Final situation will be: we have the code in a module, covered by tests
\o/

Test plan:
Check an item out
Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance)
Go to the "Your summary" at the OPAC and notice the "Links" column
Everything should work identically before and after this patch

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-07-13 18:21:38 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-07-18 11:29:40 UTC 
Architectural enhancement, not required for 23.05.x series