Bug 33954 - Add Koha::Biblio->opac_summary_html
Summary: Add Koha::Biblio->opac_summary_html
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33953
Blocks: 33949 33955 33956
  Show dependency treegraph
 
Reported: 2023-06-08 10:11 UTC by Jonathan Druart
Modified: 2023-07-18 11:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33954: Add tests (1.68 KB, patch)
2023-06-08 10:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33954: Koha::Biblio->opac_summary_html (1.50 KB, patch)
2023-06-08 10:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33954: Add tests (1.72 KB, patch)
2023-07-05 17:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33954: Koha::Biblio->opac_summary_html (1.54 KB, patch)
2023-07-05 17:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33954: Add tests (1.78 KB, patch)
2023-07-13 16:09 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 33954: Koha::Biblio->opac_summary_html (1.60 KB, patch)
2023-07-13 16:09 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 10:11:49 UTC

    
Comment 1 Jonathan Druart 2023-06-08 10:56:18 UTC
Created attachment 152150 [details] [review]
Bug 33954: Add tests
Comment 2 Jonathan Druart 2023-06-08 10:56:20 UTC
Created attachment 152151 [details] [review]
Bug 33954: Koha::Biblio->opac_summary_html
Comment 3 Jonathan Druart 2023-07-05 08:53:02 UTC
On "Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac" we are using this method from the template.

This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl.

After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl.

Final situation will be: we have the code in a module, covered by tests \o/
Comment 4 Owen Leonard 2023-07-05 17:19:32 UTC
Created attachment 153072 [details] [review]
Bug 33954: Add tests

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2023-07-05 17:19:34 UTC
Created attachment 153073 [details] [review]
Bug 33954: Koha::Biblio->opac_summary_html

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Nick Clemens (kidclamp) 2023-07-13 16:09:51 UTC
Created attachment 153413 [details] [review]
Bug 33954: Add tests

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2023-07-13 16:09:53 UTC
Created attachment 153414 [details] [review]
Bug 33954: Koha::Biblio->opac_summary_html

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-07-13 18:21:35 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-07-18 11:28:55 UTC
Not required for anything in 23.05.x series yet, we can backport later if it becomes required.