| Summary: | Use template wrapper for tabs: Recalls awaiting pickup | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Bug Depends on: | 34010 | ||
| Bug Blocks: | 32571, 34013 | ||
| Attachments: |
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup |
||
|
Description
Owen Leonard
2023-06-14 17:03:58 UTC
Created attachment 152351 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Created attachment 152358 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 152361 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=34010 Signed-off-by: David Nind <david@davidnind.com> The only thing I noticed was that the buttons (such as 'Revert waiting status' and 'Expire recall') were previously orange, but are now standard buttons with a white background. Also, I didn't refresh the bug page, and note that was already signed off. I also managed to add a bugzilla link, which I'll fix up. Created attachment 152362 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 152596 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to 22.11.x for next release |