The recall pages have not been updated to use the wrapper for breadcrumbs and many lack a .page-section container div.
Created attachment 152350 [details] [review] Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add <div class="page-section"> where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to <button> elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar.
Created attachment 152357 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau <samalau@gmail.com>
(In reply to Sam Lau from comment #2) > Created attachment 152357 [details] [review] [review] > Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup > > This patch updates the recalls awaiting pickup template so that it uses > the new WRAPPER directive to build tabbed navigation. > > Note: this patch includes indentation changes, so check the diff > accordingly. > > To test you must have UseRecalls enabled. Apply the patch and go to > Circulation -> Recalls awaiting pickup. > > Both the "Recalls waiting" and "Recalls waiting over X days" tabs should > look correct and work correctly. > > Signed-off-by: Sam Lau <samalau@gmail.com> Oops, attached wrong one
Created attachment 152359 [details] [review] Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add <div class="page-section"> where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to <button> elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152595 [details] [review] Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add <div class="page-section"> where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to <button> elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release