Bug 34010 - Template corrections to recall pages
Summary: Template corrections to recall pages
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 19532
Blocks: 34012
  Show dependency treegraph
 
Reported: 2023-06-14 15:07 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34010: Template corrections to recall pages (32.61 KB, patch)
2023-06-14 16:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup (19.60 KB, patch)
2023-06-14 18:23 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34010: Template corrections to recall pages (32.65 KB, patch)
2023-06-14 18:30 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34010: Template corrections to recall pages (32.71 KB, patch)
2023-06-22 20:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-14 15:07:16 UTC
The recall pages have not been updated to use the wrapper for breadcrumbs and many lack a .page-section container div.
Comment 1 Owen Leonard 2023-06-14 16:58:59 UTC Comment hidden (obsolete)
Comment 2 Sam Lau 2023-06-14 18:23:37 UTC Comment hidden (obsolete)
Comment 3 Sam Lau 2023-06-14 18:25:59 UTC
(In reply to Sam Lau from comment #2)
> Created attachment 152357 [details] [review] [review]
> Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup
> 
> This patch updates the recalls awaiting pickup template so that it uses
> the new WRAPPER directive to build tabbed navigation.
> 
> Note: this patch includes indentation changes, so check the diff
> accordingly.
> 
> To test you must have UseRecalls enabled. Apply the patch and go to
> Circulation -> Recalls awaiting pickup.
> 
> Both the "Recalls waiting" and "Recalls waiting over X days" tabs should
> look correct and work correctly.
> 
> Signed-off-by: Sam Lau <samalau@gmail.com>

Oops, attached wrong one
Comment 4 Sam Lau 2023-06-14 18:30:20 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2023-06-22 20:54:43 UTC
Created attachment 152595 [details] [review]
Bug 34010: Template corrections to recall pages

This patch makes some corrections to recall pages:
- Update breadcrumbs menu to use wrapper.
- Add <div class="page-section"> where it is missing.
- Use biblio-title include to show links to bibliographic record titles.
- Correct Bootstrap button dropdown markup for consistent style
- Change some submit buttons to <button> elements for consistent style

To test you must have UseRecalls enabled. Having some sample recalls
data will help. Check the following pages to confirm that everything
looks correct:

- Circulation ->
  - Recalls queue
  - Recalls to pull
  - Overdue recalls
  - Recalls awaiting pickup
  - Old recalls
  - Existing recalls: View a bibliographic record with a recall and
    click "Recalls" in the sidebar.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-06-23 12:46:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-07-17 12:46:05 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 8 Pedro Amorim 2023-07-18 10:50:35 UTC
Nice work everyone!

Pushed to 22.11.x for next release