|
Description
Caroline Cyr La Rose
2023-07-25 18:17:55 UTC
Created attachment 156458 [details] [review] Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Created attachment 156467 [details] [review] Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Signed-off-by: David Nind <david@davidnind.com> Created attachment 156468 [details] [review] Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind <david@davidnind.com> Feel free to obsolete my follow-up patch - bug 34389 (debit types) and bug 34391 (cash registers) had single quotes around the debit and cash register code values. Created attachment 156496 [details] [review] Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Created attachment 156497 [details] [review] Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 156676 [details] [review] Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156677 [details] [review] Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |