While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Cash registers page, here is what should be changed to make it consistent with the other pages in the module: Page header - Change 'Add new cash register' to 'New cash register' - Add cash register ID to page header
Created attachment 156459 [details] [review] Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers Fix inconsistencies in cash register page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Cash register. Test each variation of the page: - Main page - New cash register - Modify cash register
Created attachment 156464 [details] [review] Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers Fix inconsistencies in cash register page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Cash register. Test each variation of the page: - Main page - New cash register - Modify cash register Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Enable UseCashRegisters system preference. 2. I noticed in the patch (I don't normally look at these as I don't know what is going on!), and noticed there was 'stuff' for deleting a cash register. I can't see an option to do this in the staff interface.
Created attachment 156485 [details] [review] Bug 34391: Fix inconsistencies in cash registers titles, breadcrumbs, and headers Fix inconsistencies in cash register page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the cash register administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Cash register. Test each variation of the page: - Main page - New cash register - Modify cash register Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Not pushed to 23.05.x