Bug 37396

Summary: Batch checkout does not checkout items if OverduesBlockCirc set to ask for confirmation
Product: Koha Reporter: Laura Escamilla <Laura.escamilla>
Component: CirculationAssignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to main --- QA Contact: Kyle M Hall (khall) <kyle>
Severity: normal    
Priority: P4 CC: ddaghita, gmcharlt, kyle.m.hall, kyle, lucas, nick, sbrown
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38153
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38154
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38161
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 23780, 37424    
Attachments: Bug 37396: Add missing cud-checkout op to form
Bug 37396: Add missing cud-checkout op to form
Bug 37396: Add missing cud-checkout op to form

Description Laura Escamilla 2024-07-17 16:10:28 UTC
To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue. 
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'. 
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
Comment 1 Nick Clemens (kidclamp) 2024-07-23 16:02:02 UTC
Created attachment 169436 [details] [review]
Bug 37396: Add missing cud-checkout op to form

To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue.
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'.
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
6. Apply patch
7. Repeate batch checkout
8. Confirm the checkout
9, Items are successfully issued!
Comment 2 Matt Blenkinsop 2024-07-26 13:27:28 UTC
Created attachment 169710 [details] [review]
Bug 37396: Add missing cud-checkout op to form

To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue.
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'.
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
6. Apply patch
7. Repeate batch checkout
8. Confirm the checkout
9, Items are successfully issued!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Kyle M Hall (khall) 2024-08-23 14:57:21 UTC
Created attachment 170639 [details] [review]
Bug 37396: Add missing cud-checkout op to form

To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue.
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'.
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
6. Apply patch
7. Repeate batch checkout
8. Confirm the checkout
9, Items are successfully issued!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-08-23 16:22:28 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 davedaghita 2024-08-23 16:26:00 UTC
Thank you.  Great work!!
Comment 6 Lucas Gass (lukeg) 2024-09-12 22:37:32 UTC
Depends on Bug 23780 which has a status of NEW. Can someone clarify for me?
Comment 7 Nick Clemens (kidclamp) 2024-10-15 15:18:21 UTC
(In reply to Lucas Gass (lukeg) from comment #6)
> Depends on Bug 23780 which has a status of NEW. Can someone clarify for me?

It was pushed to main without that one, I don't see a clear dependency, I moved this one to block 23780