Bug 37396 - Batch checkout does not checkout items if OverduesBlockCirc set to ask for confirmation
Summary: Batch checkout does not checkout items if OverduesBlockCirc set to ask for co...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P4 normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks: 23780 37424
  Show dependency treegraph
 
Reported: 2024-07-17 16:10 UTC by Laura Escamilla
Modified: 2024-10-15 15:18 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37396: Add missing cud-checkout op to form (1.81 KB, patch)
2024-07-23 16:02 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 37396: Add missing cud-checkout op to form (1.89 KB, patch)
2024-07-26 13:27 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37396: Add missing cud-checkout op to form (1.94 KB, patch)
2024-08-23 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2024-07-17 16:10:28 UTC
To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue. 
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'. 
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
Comment 1 Nick Clemens (kidclamp) 2024-07-23 16:02:02 UTC
Created attachment 169436 [details] [review]
Bug 37396: Add missing cud-checkout op to form

To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue.
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'.
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
6. Apply patch
7. Repeate batch checkout
8. Confirm the checkout
9, Items are successfully issued!
Comment 2 Matt Blenkinsop 2024-07-26 13:27:28 UTC
Created attachment 169710 [details] [review]
Bug 37396: Add missing cud-checkout op to form

To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue.
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'.
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
6. Apply patch
7. Repeate batch checkout
8. Confirm the checkout
9, Items are successfully issued!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Kyle M Hall (khall) 2024-08-23 14:57:21 UTC
Created attachment 170639 [details] [review]
Bug 37396: Add missing cud-checkout op to form

To test:

1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation'
2. Enable the BatchCheckout system preference
3. Checkout an item to a patron and backdate the due date so that it is overdue.
4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'.
5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron.
6. Apply patch
7. Repeate batch checkout
8. Confirm the checkout
9, Items are successfully issued!

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-08-23 16:22:28 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 davedaghita 2024-08-23 16:26:00 UTC
Thank you.  Great work!!
Comment 6 Lucas Gass (lukeg) 2024-09-12 22:37:32 UTC
Depends on Bug 23780 which has a status of NEW. Can someone clarify for me?
Comment 7 Nick Clemens (kidclamp) 2024-10-15 15:18:21 UTC
(In reply to Lucas Gass (lukeg) from comment #6)
> Depends on Bug 23780 which has a status of NEW. Can someone clarify for me?

It was pushed to main without that one, I don't see a clear dependency, I moved this one to block 23780