Bug 37857

Summary:	Unable to select type "Geo point" or "Call number" when adding a search field
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Searching - Elasticsearch	Assignee:	Jonathan Druart <jonathan.druart>
Status:	Pushed to stable ---	QA Contact:	Nick Clemens (kidclamp) <nick>
Severity:	normal
Priority:	P5 - low	CC:	david, jonathan.druart, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00,24.05.06
Circulation function:
Bug Depends on:	18194, 20388
Bug Blocks:
Attachments:	Bug 37857: Add callnumber and geo_point for new search fields Bug 37857: Add callnumber and geo_point for new search fields Bug 37857: Add callnumber and geo_point for new search fields Bug 37857: Add callnumber and geo_point for new search fields

Description Caroline Cyr La Rose 2024-09-06 14:46:13 UTC

I was trying to document the feature introduced by bug 20388 to add a new search field in the search engine configuration (ES). I noticed the drop-down for "Type" doesn't contain "Geo point" or "Call number".

I'm not sure I fully understand the feature, so maybe it is intentional because you're not supposed to have more search fields for these types than the existing ones? If so, please clarify and I will add the precision to the manual. Right now, it just looks like an oversight.

Comment 1 Jonathan Druart 2024-09-09 09:09:23 UTC

Created attachment 171180 [details] [review]
Bug 37857: Add callnumber and geo_point for new search fields

It is missing "Geo point" and "Call Number" from the options of
"Type" when creating a new search field.

Test plan:
Go to the elastic mapping config page, bottom of the page.
Notice that after this patch you see the 2 options in the dropdown list.

Comment 2 Jonathan Druart 2024-09-09 09:09:33 UTC

Conflicts and patches pushing before others, and we end up with that kind of bugs. It's not expected all, fixed! Thanks for reporting, Caroline.

Comment 3 Jonathan Druart 2024-09-09 09:10:04 UTC

Note that I have used "Call Number" cause it's how it is displayed on the same page, but it should certainly be "Call number".

Comment 4 Katrin Fischer 2024-09-09 09:43:36 UTC

(In reply to Jonathan Druart from comment #3)
> Note that I have used "Call Number" cause it's how it is displayed on the
> same page, but it should certainly be "Call number".

Already have an open bug for that:
Bug 36609 - Update index type labels in Elasticsearch config page: Std. Number, Call Number, <empty>

I believe Call Numer an dgeo Point were added later and we missed updating the patch set from bug 18194 that had been sitting a while.

Comment 5 Chloe Zermatten 2024-09-09 13:51:15 UTC

Created attachment 171200 [details] [review]
Bug 37857: Add callnumber and geo_point for new search fields

It is missing "Geo point" and "Call Number" from the options of
"Type" when creating a new search field.

Test plan:
Go to the elastic mapping config page, bottom of the page.
Notice that after this patch you see the 2 options in the dropdown list.

Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>

Comment 6 David Nind 2024-09-09 22:24:16 UTC

Hi Chloe.

It looks like you've signed off this bug.

Please update the bug status to Signed Off, so that you will get the credit on the Dashboard at https://dashboard.koha-community.org 8-)

David

Comment 7 Caroline Cyr La Rose 2024-09-10 14:39:13 UTC

Created attachment 171251 [details] [review]
Bug 37857: Add callnumber and geo_point for new search fields

It is missing "Geo point" and "Call Number" from the options of
"Type" when creating a new search field.

Test plan:
Go to the elastic mapping config page, bottom of the page.
Notice that after this patch you see the 2 options in the dropdown list.

Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Comment 8 Nick Clemens (kidclamp) 2024-09-16 19:00:05 UTC

Created attachment 171597 [details] [review]
Bug 37857: Add callnumber and geo_point for new search fields

It is missing "Geo point" and "Call Number" from the options of
"Type" when creating a new search field.

Test plan:
Go to the elastic mapping config page, bottom of the page.
Notice that after this patch you see the 2 options in the dropdown list.

Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 9 Katrin Fischer 2024-09-17 08:50:06 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 10 Lucas Gass (lukeg) 2024-11-18 22:03:54 UTC

Backported to 24.05.x for upcoming 24.05.06