I was trying to document the feature introduced by bug 20388 to add a new search field in the search engine configuration (ES). I noticed the drop-down for "Type" doesn't contain "Geo point" or "Call number". I'm not sure I fully understand the feature, so maybe it is intentional because you're not supposed to have more search fields for these types than the existing ones? If so, please clarify and I will add the precision to the manual. Right now, it just looks like an oversight.
Created attachment 171180 [details] [review] Bug 37857: Add callnumber and geo_point for new search fields It is missing "Geo point" and "Call Number" from the options of "Type" when creating a new search field. Test plan: Go to the elastic mapping config page, bottom of the page. Notice that after this patch you see the 2 options in the dropdown list.
Conflicts and patches pushing before others, and we end up with that kind of bugs. It's not expected all, fixed! Thanks for reporting, Caroline.
Note that I have used "Call Number" cause it's how it is displayed on the same page, but it should certainly be "Call number".
(In reply to Jonathan Druart from comment #3) > Note that I have used "Call Number" cause it's how it is displayed on the > same page, but it should certainly be "Call number". Already have an open bug for that: Bug 36609 - Update index type labels in Elasticsearch config page: Std. Number, Call Number, <empty> I believe Call Numer an dgeo Point were added later and we missed updating the patch set from bug 18194 that had been sitting a while.
Created attachment 171200 [details] [review] Bug 37857: Add callnumber and geo_point for new search fields It is missing "Geo point" and "Call Number" from the options of "Type" when creating a new search field. Test plan: Go to the elastic mapping config page, bottom of the page. Notice that after this patch you see the 2 options in the dropdown list. Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
Hi Chloe. It looks like you've signed off this bug. Please update the bug status to Signed Off, so that you will get the credit on the Dashboard at https://dashboard.koha-community.org 8-) David
Created attachment 171251 [details] [review] Bug 37857: Add callnumber and geo_point for new search fields It is missing "Geo point" and "Call Number" from the options of "Type" when creating a new search field. Test plan: Go to the elastic mapping config page, bottom of the page. Notice that after this patch you see the 2 options in the dropdown list. Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 171597 [details] [review] Bug 37857: Add callnumber and geo_point for new search fields It is missing "Geo point" and "Call Number" from the options of "Type" when creating a new search field. Test plan: Go to the elastic mapping config page, bottom of the page. Notice that after this patch you see the 2 options in the dropdown list. Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06