Bug 36609 - Update index type labels in Elasticsearch config page: Std. Number, Call Number, <empty>
Summary: Update index type labels in Elasticsearch config page: Std. Number, Call Numb...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Nind
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2024-04-16 15:31 UTC by Katrin Fischer
Modified: 2025-04-17 06:56 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the labels used for the type options when configuring Elasticsearch search fields - they now use sentence case and the full name (instead of abbreviations): - Default (instead of being blank) - Identifier (instead of Std. Number) - Call number (instead of Call Number)
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Bug 36609: Update index type labels for search engine configuration (3.81 KB, patch)
2024-12-08 18:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 36609: Update index type labels for search engine configuration (4.97 KB, patch)
2024-12-08 18:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 36609: Update index type labels for search engine configuration (5.02 KB, patch)
2024-12-09 12:45 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-04-16 15:31:58 UTC
the N should be n, but also: maybe we should use Standard number instead of the abbreviation? Might be less confusing especially for translators.
Comment 1 Katrin Fischer 2024-04-16 15:33:14 UTC
From discussion in chat: We might want to rename Std. number to Identifier.
Comment 2 Katrin Fischer 2024-04-17 11:36:42 UTC
After some discussion in chat:

Std. Number = Standard number or Identifier
Call Number = Call number
<empty entry> = Default
Comment 3 David Nind 2024-12-08 18:36:02 UTC
Links to the discussion threads from April 2024:
- Default instead of blank: https://chat.koha-community.org/koha-community/pl/wgdqrbghtb8qdrb7rkd6f6k8my
- Identifier instead of Std. Number or Standard Number: https://chat.koha-community.org/koha-community/pl/p37r6fp43tgym89wxtmwqbzrph
Comment 4 David Nind 2024-12-08 18:36:42 UTC Comment hidden (obsolete)
Comment 5 David Nind 2024-12-08 18:48:49 UTC
Created attachment 175283 [details] [review]
Bug 36609: Update index type labels for search engine configuration

This fixes the labels used for the type options when configuring
Elasticsearch search fields so that they use:
- sentence case
- the full name, instead of abbreviations (to make it clearer
  for translators)

Test plan:
1. Go to Administration > Catalog > Search engine
   configuration (Elasticsearch).
2. In the search fields tab, select the type column dropdown list
   for any field. Note the labels used for these options:
   - <empty entry> (the default option)
   - Std. Number
   - Call Number
3. Apply the patch.
4. Refresh the page.
5. Repeat step 2 and note that the option labels are now:
   - Default (instead of being blank)
   - Identfier (instead of Std. Number)
   - Call number (instead of Call Number)
6. Sign off D:
Comment 6 Owen Leonard 2024-12-09 12:45:27 UTC
Created attachment 175308 [details] [review]
Bug 36609: Update index type labels for search engine configuration

This fixes the labels used for the type options when configuring
Elasticsearch search fields so that they use:
- sentence case
- the full name, instead of abbreviations (to make it clearer
  for translators)

Test plan:
1. Go to Administration > Catalog > Search engine
   configuration (Elasticsearch).
2. In the search fields tab, select the type column dropdown list
   for any field. Note the labels used for these options:
   - <empty entry> (the default option)
   - Std. Number
   - Call Number
3. Apply the patch.
4. Refresh the page.
5. Repeat step 2 and note that the option labels are now:
   - Default (instead of being blank)
   - Identfier (instead of Std. Number)
   - Call number (instead of Call Number)
6. Sign off D:

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 David Nind 2024-12-09 17:54:05 UTC
Thanks for the sign off Owen!
Comment 8 Katrin Fischer 2024-12-27 15:25:19 UTC
QA by RM
Comment 9 Katrin Fischer 2024-12-27 16:36:11 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 10 Paul Derscheid 2025-03-19 23:00:28 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03
Comment 11 Wainui Witika-Park 2025-04-17 06:56:21 UTC
Not backporting to 24.05.x unless requested