Bug 37912

Summary: Catalog concerns - Broken link under concern title
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Needs documenting --- QA Contact: Aleisha Amohia <aleisha>
Severity: normal    
Priority: P5 - low CC: aleisha, fridolin.somers, lucas, martin.renvoize, phil, sam.sowanick, wainuiwitikapark
Version: MainKeywords: regression
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 37910    
Bug Blocks: 34324    
Attachments: Bug 37912: Restore detail-trigger handling
Bug 37912: Restore detail-trigger handling
Bug 37912: Restore detail-trigger handling
Bug 37912: Restore detail-trigger handling

Description Caroline Cyr La Rose 2024-09-12 20:42:15 UTC
In the catalog concerns page, nothing happens when you click on the title of a concern.

To recreate:
1. Enable the CatalogConcerns system preference
2. In a bibliographic record, click New > New catalog concern 
3. Fill out the title (and optionally the description)
4. Click Submit
5. Go to Cataloging > Catalog concerns
6. Click on the title of the concern
   --> Nothing happens

According to the manual, it used to lead to the concern details modal.
Comment 1 Phil Ringnalda 2024-09-13 17:33:38 UTC
It still tries to, https://git.koha-community.org/Koha-community/Koha/src/commit/ea17ce2ffa1f2db88f85e86646513dde34d24eed/koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js#L3 thinks when you click on the link it will find and .click() the button at the end of the table row. It just doesn't find it.
Comment 2 Martin Renvoize (ashimema) 2024-10-29 15:20:50 UTC
Created attachment 173662 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.
Comment 3 Biblibre Sandboxes 2024-10-29 17:27:32 UTC
Created attachment 173684 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 4 Biblibre Sandboxes 2024-10-29 17:27:35 UTC
Created attachment 173685 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 5 Aleisha Amohia 2024-11-06 03:09:14 UTC
Created attachment 174059 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 6 Katrin Fischer 2024-11-07 16:33:51 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-12-05 21:52:51 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-18 10:55:35 UTC
Depends on Bug 37910 not in 23.11.x
Comment 9 Wainui Witika-Park 2024-12-19 01:00:37 UTC
(In reply to Lucas Gass (lukeg) from comment #7)
> Backported to 24.05.x for upcoming 24.05.06

I'm going to revert this as this bug depends on patches not in 24.05.x