Bug 34324 - Merge OPACProblemReport and CatalogConcern functions
Summary: Merge OPACProblemReport and CatalogConcern functions
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
: 25466 (view as bug list)
Depends on: 35287 35625 37912 4461 35616 35628
Blocks: 34255
  Show dependency treegraph
 
Reported: 2023-07-20 13:08 UTC by Martin Renvoize (ashimema)
Modified: 2024-10-29 15:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 34324: Add opac_problem to source enum of tickets (1.14 KB, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add relationship aliases (1.72 KB, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add support for additional fields to /tickets (2.90 KB, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add additional_field_value to definitions (1.65 KB, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: API Tests (704 bytes, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Make biblio_id a nullable field (870 bytes, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add 'Report a problem' modal (8.17 KB, patch)
2023-12-21 14:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add page_url to additional_fields (874 bytes, patch)
2023-12-21 14:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add opac_problem to source enum of tickets (1.14 KB, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add relationship aliases (1.72 KB, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add support for additional fields to /tickets (2.89 KB, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add additional_field_value to definitions (1.61 KB, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: API Tests (910 bytes, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Make biblio_id a nullable field (870 bytes, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add 'Report a problem' modal (8.31 KB, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add page_url to additional_fields (849 bytes, patch)
2024-10-28 17:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add opac_problem to source enum of tickets (1.14 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add relationship aliases (1.72 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add support for additional fields to /tickets (2.89 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add additional_field_value to definitions (1.61 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: API Tests (910 bytes, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Make biblio_id a nullable field (870 bytes, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add 'Report a problem' modal (8.31 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add page_url to additional_fields (849 bytes, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Next steps commented (1.04 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 34324: Add preview to catalog concerns summary table (1.95 KB, patch)
2024-10-29 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2023-07-20 13:08:22 UTC
I initially looked at adding the Catalog Concerns functionality into the existing OPAC Problem reports feature but quick found that troublesome. However, I still think the two sets of functionality can be merged and I designed the Catalog Concerns data structure and api's with that in mind.

We should start migrating the OPAC Problem reports functionality into the Catalog concerns 'tickets' structure as the beginnings of a new 'Enquiries' module.
Comment 1 Martin Renvoize (ashimema) 2023-07-20 13:15:52 UTC
*** Bug 25466 has been marked as a duplicate of this bug. ***
Comment 2 Martin Renvoize (ashimema) 2023-12-21 14:31:02 UTC
Only 'Bug 35287: Preparation: Extend AdditionalFields Mixin' is actually required from bug 35287 in the dependencies.. I'm tempted to split that out into it's own bug.
Comment 3 Martin Renvoize (ashimema) 2023-12-21 14:31:44 UTC
Created attachment 160199 [details] [review]
Bug 34324: Add opac_problem to source enum of tickets
Comment 4 Martin Renvoize (ashimema) 2023-12-21 14:31:46 UTC
Created attachment 160200 [details] [review]
Bug 34324: Add relationship aliases
Comment 5 Martin Renvoize (ashimema) 2023-12-21 14:31:49 UTC
Created attachment 160201 [details] [review]
Bug 34324: Add support for additional fields to /tickets

We need to store page_url as part of the opac_report functionality.

Rather than adding fields to the core tickets table, it makes sense to
utilise the additional_fields functionality.
Comment 6 Martin Renvoize (ashimema) 2023-12-21 14:31:51 UTC
Created attachment 160202 [details] [review]
Bug 34324: Add additional_field_value to definitions
Comment 7 Martin Renvoize (ashimema) 2023-12-21 14:31:54 UTC
Created attachment 160203 [details] [review]
Bug 34324: API Tests
Comment 8 Martin Renvoize (ashimema) 2023-12-21 14:31:57 UTC
Created attachment 160204 [details] [review]
Bug 34324: Make biblio_id a nullable field
Comment 9 Martin Renvoize (ashimema) 2023-12-21 14:31:59 UTC
Created attachment 160205 [details] [review]
Bug 34324: Add 'Report a problem' modal

This patch adds a modal for reporting opac problems. This will allow us
to remove the controller and template code for the feature.
Comment 10 Martin Renvoize (ashimema) 2023-12-21 14:32:02 UTC
Created attachment 160206 [details] [review]
Bug 34324: Add page_url to additional_fields
Comment 11 Martin Renvoize (ashimema) 2023-12-21 14:38:11 UTC
Work in progress.. still to do.
1) Re-implement/extend tickets endpoint to accept a target for who to notify by email on new submissions (we already do this for catalogue concerns, but it's hard coded to cataloguer email.. maybe we should expose it in a header as an option instead... or perhaps bing on source + audience)
2) Convert staff side interface to use the display framework built for catalog concerns.
3) Migrate existing problem reports into tickets
4) Drop the old controllers and tables
Comment 12 Martin Renvoize (ashimema) 2024-10-28 17:44:43 UTC
Created attachment 173580 [details] [review]
Bug 34324: Add opac_problem to source enum of tickets
Comment 13 Martin Renvoize (ashimema) 2024-10-28 17:44:45 UTC
Created attachment 173581 [details] [review]
Bug 34324: Add relationship aliases
Comment 14 Martin Renvoize (ashimema) 2024-10-28 17:44:47 UTC
Created attachment 173582 [details] [review]
Bug 34324: Add support for additional fields to /tickets

We need to store page_url as part of the opac_report functionality.

Rather than adding fields to the core tickets table, it makes sense to
utilise the additional_fields functionality.
Comment 15 Martin Renvoize (ashimema) 2024-10-28 17:44:50 UTC
Created attachment 173583 [details] [review]
Bug 34324: Add additional_field_value to definitions
Comment 16 Martin Renvoize (ashimema) 2024-10-28 17:44:52 UTC
Created attachment 173584 [details] [review]
Bug 34324: API Tests
Comment 17 Martin Renvoize (ashimema) 2024-10-28 17:44:55 UTC
Created attachment 173585 [details] [review]
Bug 34324: Make biblio_id a nullable field
Comment 18 Martin Renvoize (ashimema) 2024-10-28 17:44:57 UTC
Created attachment 173586 [details] [review]
Bug 34324: Add 'Report a problem' modal

This patch adds a modal for reporting opac problems. This will allow us
to remove the controller and template code for the feature.
Comment 19 Martin Renvoize (ashimema) 2024-10-28 17:44:59 UTC
Created attachment 173587 [details] [review]
Bug 34324: Add page_url to additional_fields
Comment 20 Martin Renvoize (ashimema) 2024-10-29 15:46:17 UTC
Created attachment 173671 [details] [review]
Bug 34324: Add opac_problem to source enum of tickets
Comment 21 Martin Renvoize (ashimema) 2024-10-29 15:46:20 UTC
Created attachment 173672 [details] [review]
Bug 34324: Add relationship aliases
Comment 22 Martin Renvoize (ashimema) 2024-10-29 15:46:22 UTC
Created attachment 173673 [details] [review]
Bug 34324: Add support for additional fields to /tickets

We need to store page_url as part of the opac_report functionality.

Rather than adding fields to the core tickets table, it makes sense to
utilise the additional_fields functionality.
Comment 23 Martin Renvoize (ashimema) 2024-10-29 15:46:24 UTC
Created attachment 173674 [details] [review]
Bug 34324: Add additional_field_value to definitions
Comment 24 Martin Renvoize (ashimema) 2024-10-29 15:46:27 UTC
Created attachment 173675 [details] [review]
Bug 34324: API Tests
Comment 25 Martin Renvoize (ashimema) 2024-10-29 15:46:29 UTC
Created attachment 173676 [details] [review]
Bug 34324: Make biblio_id a nullable field
Comment 26 Martin Renvoize (ashimema) 2024-10-29 15:46:32 UTC
Created attachment 173677 [details] [review]
Bug 34324: Add 'Report a problem' modal

This patch adds a modal for reporting opac problems. This will allow us
to remove the controller and template code for the feature.
Comment 27 Martin Renvoize (ashimema) 2024-10-29 15:46:34 UTC
Created attachment 173678 [details] [review]
Bug 34324: Add page_url to additional_fields
Comment 28 Martin Renvoize (ashimema) 2024-10-29 15:46:37 UTC
Created attachment 173679 [details] [review]
Bug 34324: Next steps commented
Comment 29 Martin Renvoize (ashimema) 2024-10-29 15:46:39 UTC
Created attachment 173680 [details] [review]
Bug 34324: Add preview to catalog concerns summary table

This patch adds the first 80 characters of the body of the message as a
preview in the details field of the summary page of catalog concerns.

This is to bring us more in line with what OPAC Problem reports
currently displays in it's table.
Comment 30 Martin Renvoize (ashimema) 2024-10-29 15:47:44 UTC
Rebased and ready for next steps when I get a moment